374579 - [regression] list-style-image painted all over the place

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[philippe (part-time)]

Attachment: testcase

ul {list-style-image:my.gif}or li {list-style-image:my.gif} are painted all over their parent block.
This gives some interesting effects like in the url above. 

This is a regression form bug 371434.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a3pre) Gecko/20070319 Minefield/3.0a3pre ID:2007031921 [cairo]

Comment 1

[-fullmetaljacket-]

hardware -> ALL
os -> ALL

i am also seeing this on win xp

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070319 Minefield/3.0a3pre ID:2007031919 [cairo]

Comment 2

[Jesse Ruderman]

This borks Wikipedia, too.  (e.g. http://en.wikipedia.org/wiki/Firefox)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hrm.  So this seems to work fine on Linux, but I see the bug on Windows.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Found the problem -- I was using aDirtyRect instead of dirtyRect in nsLayoutUtils::DrawImage, causing massively negative srcRect coordinates to be passed to the image code.  The bug shows up when the negative coordinates get clamped to zero; it works fine when they don't.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070320 Minefield/3.0a3pre ID:2007032012 [cairo]

verified/fixed

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070321
SeaMonkey/1.5a] (nightly) (W2Ksp4)

(Confirming) V.Fixed, per bug 374611.