374632 - A separate script just to fix file/directory permissions

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P4)

Description

[Max Kanat-Alexander]

Now that checksetup is localizeable, it depends on being able to access the template/ directory. Also, setup.cgi looks nicer if it has access to the skins/ directory.

If we can't access the template/ directory, checksetup can't even run.

So, we need a separate script, probably called fix-permissions.pl, that just fixes file permissions so that things can be accessed. If we haven't created a localconfig yet, it should just act like we have a blank webservergroup, which makes sense.

Also, we can run that on a Bugzilla tarball when we build it, so that permissions will be the "no webservergroup" permissions by default. (Which probably won't matter too much, but hey.)

Comment 1

[Max Kanat-Alexander]

This is no longer all that important now that I'm not working on web-based installation.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here's a ridiculously-simple contrib script to do it.

Comment 3

[Max Kanat-Alexander]

  Might as well check it in to 3.4 as well, since it's just a contrib script.

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
added contrib/fixperms.pl
Committed revision 7059.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
added contrib/fixperms.pl
Committed revision 7027.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/
added contrib/fixperms.pl
Committed revision 6745.

Comment 5

[Frédéric Buclin]

Why is this script useful? Why not just run checksetup.pl? Per comment 1, this script is not needed.

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> Why is this script useful? Why not just run checksetup.pl? Per comment 1, this
> script is not needed.

  It's needed because it's instantaneous and it sets permissions properly. The problem is that checksetup.pl -t takes a long time (in some sense--a few seconds, or a minute at most), and while it's running, you can't use Bugzilla. At least the last time I checked, checksetup.pl first sets permissions wrongly and then sets the rightly, whereas this script is nearly instantaneous and just sets permissions properly. It's useful in situations like Mozilla's, where they want to correct the permissions of files right after they're checked out, but they know checksetup.pl doesn't need to be run, and it's useful during development, when I'm updating or reverting a lot and want to just fix permissions quickly without having to wait for all of checksetup to run.

Comment 7

[Michael Thomas (Mockodin)]

mkanat, why not a commandline switch on checksetup to do only permissions?

Comment 8

[Max Kanat-Alexander]

(In reply to comment #7)
> mkanat, why not a commandline switch on checksetup to do only permissions?

  Because that's a PITA and this was a four-line-or-so script.