Closed Bug 374633 Opened 14 years ago Closed 14 years ago

Spellcheck doesn't work in pt-PT Thunderbird

Categories

(Mozilla Localizations :: pt-PT / Portuguese, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: joao.neves)

Details

(Keywords: verified1.8.1.4)

Attachments

(1 file)

pt-PT locale have spellcheck dictionary but it doesn't work in Thunderbird.
# I think this is important feature and requesting blocking-thunderbird2.

You should add below line to pt-PT/mail/all-l10n.js like en-US did in bug 373787.
  pref("spellchecker.dictionary", "pt_PT");
                                   ~~~~~
Note: your dictionary filename is pt_PT.dic/pt_PT.aff and the value should be "pt_PT", not "pt-PT".

FYI: Firefox will automatically set the pref when we load a page including textbox and you don't have to add the pref to browser/firefox-l10n.js.
Flags: blocking-thunderbird2?
This is the patch.
Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

Scott, I think this patch could be something we'd still want to take. Risk is low, and I can land it on the branch tomorrow morning my time, if you approve it.
Attachment #259130 - Flags: approval1.8.1.4?
Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

I verified that the other locales besides this one and zh-TW that ship dictionaries are setting spellchecker.dictionary correctly.
Attachment #259130 - Flags: approval1.8.1.4? → approval1.8.1.4+
Scott, is that an approval?
yup, if you can land it right now, that would be great, otherwise Axel is going to land it when he wakes up.
OK. Done. Commited. Thank you all.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
adding the fixed1.8.1.4 keyword since this was checked into the branch. Thanks João.
Keywords: fixed1.8.1.4
we didn't block on this but we did take the fix. flag cleanup.
Flags: blocking-thunderbird2?
verified fixed 1.8.1.4 (Thunderbird 2.0.0.4) with Mozilla/5.0 (Windows; U; Windows NT 5.0; pt-PT; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 ID:2007060411 the spellcheck is now working as expected - adding verified keyword
You need to log in before you can comment on or make changes to this bug.