Spellcheck doesn't work in pt-PT Thunderbird

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bugzilla, Assigned: joao.neves)

Tracking

({verified1.8.1.4})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
pt-PT locale have spellcheck dictionary but it doesn't work in Thunderbird.
# I think this is important feature and requesting blocking-thunderbird2.

You should add below line to pt-PT/mail/all-l10n.js like en-US did in bug 373787.
  pref("spellchecker.dictionary", "pt_PT");
                                   ~~~~~
Note: your dictionary filename is pt_PT.dic/pt_PT.aff and the value should be "pt_PT", not "pt-PT".

FYI: Firefox will automatically set the pref when we load a page including textbox and you don't have to add the pref to browser/firefox-l10n.js.
Flags: blocking-thunderbird2?
(Reporter)

Comment 1

12 years ago
Created attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

This is the patch.

Comment 2

12 years ago
Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

Scott, I think this patch could be something we'd still want to take. Risk is low, and I can land it on the branch tomorrow morning my time, if you approve it.
Attachment #259130 - Flags: approval1.8.1.4?

Comment 3

12 years ago
Comment on attachment 259130 [details] [diff] [review]
add spellchecker.dictionary pref in all-l10n.js

I verified that the other locales besides this one and zh-TW that ship dictionaries are setting spellchecker.dictionary correctly.
Attachment #259130 - Flags: approval1.8.1.4? → approval1.8.1.4+
(Assignee)

Comment 4

12 years ago
Scott, is that an approval?

Comment 5

12 years ago
yup, if you can land it right now, that would be great, otherwise Axel is going to land it when he wakes up.
(Assignee)

Comment 6

12 years ago
OK. Done. Commited. Thank you all.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 7

12 years ago
adding the fixed1.8.1.4 keyword since this was checked into the branch. Thanks João.
Keywords: fixed1.8.1.4

Comment 8

12 years ago
we didn't block on this but we did take the fix. flag cleanup.
Flags: blocking-thunderbird2?
verified fixed 1.8.1.4 (Thunderbird 2.0.0.4) with Mozilla/5.0 (Windows; U; Windows NT 5.0; pt-PT; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 ID:2007060411 the spellcheck is now working as expected - adding verified keyword
Keywords: fixed1.8.1.4 → verified1.8.1.4
You need to log in before you can comment on or make changes to this bug.