374640 - places-bookmarks builds, a slightly old trunk profile on fresh trunk: no bookmarks toolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

places-bookmarks builds, a slightly old trunk profile on fresh trunk:  no bookmarks toolbar

my build is from:

checkout finish: Mon Mar 19 13:51:20 PDT 2007

here's the console output.

h-167:~/Desktop/trunk-no-places/debug-build/dist/MinefieldDebug.app/Contents/MacOS sspitzer$ ./firefox-bin -ProfileManager
WARNING: NS_ENSURE_TRUE(compMgr) failed: file nsComponentManagerUtils.cpp, line 90
WARNING: NS_ENSURE_TRUE(compMgr) failed: file nsComponentManagerUtils.cpp, line 90
WARNING: NS_ENSURE_TRUE(compMgr) failed: file nsComponentManagerUtils.cpp, line 90
Type Manifest File: /Users/sspitzer/Desktop/trunk-no-places/debug-build/dist/MinefieldDebug.app/Contents/MacOS/components/xpti.dat
*** Registering Apprunner components (all right -- a generic module!)
WARNING: Failed to map file: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 1165
WARNING: Failed to map file: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 1165
WARNING: dependent window created without a parent: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 419
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1085
++WEBSHELL 0x2187c80 == 1
++DOMWINDOW == 1
++DOMWINDOW == 2
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
pldhash: for the table at address 0x212d7b0, the given entrySize of 60 probably favors chaining over double hashing.
Note: styleverifytree is disabled
Note: frameverifytree is disabled
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
Note: verifyreflow is disabled
--WEBSHELL 0x2187c80 == 0
WARNING: nsExceptionService ignoring thread destruction after shutdown: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsExceptionService.cpp, line 191
--DOMWINDOW == 1
--DOMWINDOW == 0
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1025
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1025
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1122
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1122
nsStringStats
 => mAllocCount:           7261
 => mReallocCount:          534
 => mFreeCount:            5349  --  LEAKED 1912 !!!
 => mShareCount:           4285
 => mAdoptCount:           1048
 => mAdoptFreeCount:       1048
h-167:~/Desktop/trunk-no-places/debug-build/dist/MinefieldDebug.app/Contents/MacOS sspitzer$ Type Manifest File: /Users/sspitzer/Library/Application Support/Firefox/Profiles/12x466wb.default/xpti.dat
*** Registering Apprunner components (all right -- a generic module!)
WARNING: Failed to map file: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 1165
WARNING: Failed to map file: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 1165
*** General: Reading Status File: /Users/sspitzer/Desktop/trunk-no-places/debug-build/dist/MinefieldDebug.app/Contents/MacOS/updates/0/update.status
*** UpdateService: _postUpdateProcessing: No Status, No Update
*** UpdateManager: _loadXMLFileIntoArray: XML File does not exist
WARNING: XPCOM objects created/destroyed from static ctor/dtor: 'gActivityTLS != BAD_TLS_INDEX && NS_PTR_TO_INT32(PR_GetThreadPrivate(gActivityTLS)) == 0', file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpcom/base/nsTraceRefcntImpl.cpp, line 1085
++WEBSHELL 0x19321bd0 == 1
WARNING: NS_ENSURE_TRUE(cv) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/xpfe/appshell/src/nsXULWindow.cpp, line 1544
++DOMWINDOW == 1
++DOMWINDOW == 2
pldhash: for the table at address 0x32e1388c, the given entrySize of 48 probably favors chaining over double hashing.
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
JavaScript error: , line 0: uncaught exception: [Exception... "ServiceManager::GetService returned failure code:"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/places/controller.js :: <TOP_LEVEL> :: line 1531"  data: no]
++WEBSHELL 0x32e64410 == 2
++DOMWINDOW == 3
++DOMWINDOW == 4
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
JavaScript error: , line 0: uncaught exception: [Exception... "ServiceManager::GetService returned failure code:"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/places/controller.js :: <TOP_LEVEL> :: line 1531"  data: no]
Note: styleverifytree is disabled
Note: frameverifytree is disabled
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
pldhash: for the table at address 0x35e210d0, the given entrySize of 60 probably favors chaining over double hashing.
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.h, line 69
WARNING: NS_ENSURE_TRUE(bookmarks) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 1814
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsINavHistoryService.executeQueries]"  nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame :: chrome://browser/content/places/menu.xml :: set_place :: line 275"  data: no]
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
JavaScript error: chrome://global/content/bindings/tabbox.xml, line 230: uncaught exception: [Exception... "ServiceManager::GetService returned failure code:"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: anonymous :: line 75"  data: no]
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 924
++WEBSHELL 0x36600470 == 3
++DOMWINDOW == 5
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
WARNING: empty langgroup: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/gfx/thebes/src/gfxFont.cpp, line 472
Note: verifyreflow is disabled
++DOMWINDOW == 6
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.h, line 69
WARNING: NS_ENSURE_TRUE(bookmarks) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 1814
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsINavHistoryService.executeQueries]"  nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame :: chrome://browser/content/places/menu.xml :: set_place :: line 275"  data: no]
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /Users/sspitzer/Desktop/trunk-no-places/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 187
JavaScript error: , line 0: uncaught exception: [Exception... "ServiceManager::GetService returned failure code:"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: anonymous :: line 75"  data: no]

Comment 1

[Dietrich Ayala (:dietrich)]

i'm quite sure this is because of the schema changes i've made so far to the bookmarks tables.

before we turn on places bookmarks by default we'll need a solid upgrade/downgrade story for the db. however, to fix this bug and to remove the blockage caused by not being able make a few core changes that are required (bug 372501, bug 372817), i think i'm going to do it manually: make some assertions about the schema, and if it's deemed to be too old, re-init the bookmarks portion of the db (dump and recreate the bookmarks tables and re-import bookmarks.html). this will allow upgrades to avoid schema conflicts like this, trunk users to not lose history, as well as allowing development to move forward. after this change, i can work on a proper schema-version-managed up/downgrade solution.

Comment 2

[Dietrich Ayala (:dietrich)]

conversed w/ seth on irc, and the approach we talked about is this:

1. write out bookmark backups on shutdown (bug 374876, this needs to happen anyways per PRD requirements)

2. get schema versioning in place (bug 373239)

3. re-initialize bookmarks tables, and re-import the bookmarks backup on startup if a schema change is detected (also bug 373239).

blunt approach, but should suffice until we start tackling the places-wide import/export/upgrade/downgrade as specified in the Fx3 PRD. a followup issue is that not all bookmarks bits are supported via import/export at the moment.

Comment 3

[(not reading, please use [e-mail] instead)]

> conversed w/ seth on irc, and the approach we talked about is this

Thanks for commenting on the approach for bookmarks (note, history, while in places.sqlite, is another beast.)

Do you still think we need a separate bug on supporting up/downgrades via this scheme?

> a followup issue is that not all bookmarks bits are supported via 
> import/export at the moment.

doing a quick scan of all open places bugs, I see bug #334758, bug #335961 and bug #371812 on this issue, but there might be other issues for which we don't have bugs yet.

Comment 4

[Dietrich Ayala (:dietrich)]

fixed by bug 374640.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv