374827 - should make assertions fatal on Firefox debug Mac OS X tinderbox

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect, P3)

Description

[David Baron :dbaron:]

We need to change the configuration of the debug/leak-test Mac OS X tinderbox (proposed in bug 374823) on the Firefox tree so that assertions were fatal.  (We used to have a fatal assertions Linux tinderbox, but the configuration was changed, and then we regressed so that it would be orange if we turned it back on.)

I will mark things that need to happen before we do this as dependencies of this bug (although not necessarily immediately).

Comment 1

[David Baron :dbaron:]

bug 382194 currently seems to be the only assertion in the tinderbox logs.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Patch

This is a little early -- bug 396833 still needs to be fixed -- but I want to get this in as soon as possible after that fix so we can start catching regressions (like that bug!) as soon as possible before new ones appear, and that means I need review now instead of when that bug's fixed.

This URL says I modified the right file/branch:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1190368680.1190369130.22557.gz&fulltext=1

Is there a good way to make sure this change doesn't get lost if the tinderbox ever pulls its config from a different branch or something, or if it's replaced by a new one that pulls from a different branch without the fix?

Comment 3

[David Baron :dbaron:]

Comment on attachment 281815 [details] [diff] [review]
Patch

r=dbaron.  And yes, this looks like the test_mem branch to me.

Comment 4

[Jeff Walden [:Waldo]]

Fixed!