374852 - better exceptions in pyxpcom

Status: RESOLVED WONTFIX

(Other Applications Graveyard :: PyXPCOM, defect)

Description

[Shane Caraveo]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

pyxpcom exceptions do not pass xpcom boundaries, and there is no way to get the message from COMException in JavaScript.  

This patch makes COMException a nsIException, and uses nsIStackFrame to provide deeper details in the exception.  This allows the exception to be handled in JavaScript.

It also catches exceptions (eg. javascript component called from pyxpcom component) and patches them up a bit by adding the pyxpcom layer to the "inner" member.  That way, if the exception is ultimately caught in javascript, you can still see where in python the exception occurred.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Shane Caraveo]

Attachment: pyxpcom_xpcom_exceptions.patch

Comment 2

[Shane Caraveo]

Attachment: exceptions.patch

this patch is not for general use, it has some debug statements I have added to help figure out an issue I am reviewing with MarkH

Comment 3

[Shane Caraveo]

Attachment: c level exception handling

cleaned up patch.  PyErr_Clear is not necessary to call if we return NULL to python.  Returning NULL allows the exception object created in python to get passed through properly.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 259265 [details] [diff] [review]
pyxpcom_xpcom_exceptions.patch

Almost certainly out of date - sorry about that

Comment 5

[Todd Whiteman]

Expired.