375054 - When import mail,after selecting 'communicator',click 'next',no response.

Status: NEW

(MailNews Core :: Import, defect, P5)

Description

[lijuan wang]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.2) Gecko/20070312 Firefox/2.0.0.2
Build Identifier: version2 beta 2 (2007031216)

1.address books can have the same name. 2.When import mail,after selecting 'communicator',click 'next',no response.

Reproducible: Always

Steps to Reproduce:
Test on vermillion_build61_dev_XSparc

1.Go to Tools | Import 
2.Click on the "Mail" radio button 
3.Await a dialog which pops up, asking you which mail program to import the mail from. 
4.selecting 'communicator',click 'next'
5.Go to Tools | Import 
6.Click on the "Address books" radio button
7.Import an address book and name it as 'address book 1'
8.Repeat steps 5,6
9.Import an another address book and name it as 'address book 1'
Actual Results:  
After#5: no response.You can only 'Cancel' this action.
After#7: there is an 'address book 1' in address book
After#9: there is two 'address book 1' in address book

Expected Results:  
After#5: it should give a signal to tell me what to do next or whether it's successful or failed
After#7: there is an 'address book 1' in address book
After#9: can the address books have the same name?

Comment 1

[Mark Banner (:standard8)]

Having address books of the same name, although possibly confusing, doesn't actually cause any problems in the address book and is actually covered in bug 46050 - therefore removing that from the title.

Do you have a previous netscape communicator build that you used where you would be able to import mail from? (asusming this bug didn't exist).

Can you look at the Error Console and see if you get any messages appear when you click next (if so, please paste them back here in bugzilla)?

Comment 2

[lijuan wang]

I didn't use communicator before.I only saw the 'communicator' on 'import' dialog.
There is no information on Error Console.

Comment 3

[lijuan wang]

sorry.The information as follows:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIComm4xProfile.getProfileList]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/importDialog.js :: ImportMail :: line 675"  data: no]

Comment 4

[Mark Banner (:standard8)]

It looks like you can't actually import mail from communicator on solaris (even if you have used it before) - the bug here is we're not displaying the right information at the right time (e.g. an error dialog).

So confirming as I can see where the error is, and moving to Core/Mailnews Import as that's the proper location for this bug.

Comment 5

[Mark Banner (:standard8)]

Attachment: Fix part 1 (checked in)

This is part one of the fix: Catch the exception being thrown so we handle it correctly, and add a string that SeaMonkey is missing (its already defined for Thunderbird).

To test: ensure you haven't got any netscape profiles, then try and import Mail from communicator.

Part 2 of the fix will probably be to only build the communicator import code on platforms where we are able to import from it.

Comment 6

[[e-mail]]

Comment on attachment 259458 [details] [diff] [review]
Fix part 1 (checked in)

>           var length = {value:0};
>-          var profileList = comm4xprofile.getProfileList(length);
>+          var profileList = null;
>+          try {
>+            profileList = comm4xprofile.getProfileList(length);
>+          }
>+          catch (ex) {} // errorValue defaults to true
>           if (profileList)
I don't like that errorValue comment. I notice that it can return an empty profile list, which confuses the code into showing a list of zero elements; maybe the code should check the length value instead?

>+ImportMailFailed=An error occurred importing mail from %S
I don't actually see where this gets used?

Comment 7

[[e-mail]]

(In reply to comment #5)
>Part 2 of the fix will probably be to only build the communicator import code
>on platforms where we are able to import from it.
You'd have to tweak the front end code a bit, it doesn't create the component gracefully (the null checks it uses are pointless).

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #6)
> I don't like that errorValue comment. I notice that it can return an empty
> profile list, which confuses the code into showing a list of zero elements;
> maybe the code should check the length value instead?

That sounds reasonable.

> >+ImportMailFailed=An error occurred importing mail from %S
> I don't actually see where this gets used?

I didn't until I tested it... then I found these lines:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/import/resources/content/importDialog.js&rev=1.40&mark=445-446#440

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 259458 [details] [diff] [review]
Fix part 1 (checked in)

Checked in with Neil's comments addressed.

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I'm wondering about the continued relevance of this bug since communicator support is starting to get dropped..

Thoughts?