Closed
Bug 375075
Opened 18 years ago
Closed 18 years ago
Stop leaking the cycle collector on shutdown
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: peterv, Assigned: peterv)
References
Details
(Keywords: memory-leak, regression)
Attachments
(1 file, 1 obsolete file)
|
24.40 KB,
patch
|
peterv
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•18 years ago
|
||
This undoes most of the patch for bug 369336.
Attachment #259406 -
Flags: review?(benjamin)
|
||
Comment 2•18 years ago
|
||
Isn't this a dupe of bug 373870?
|
||
Comment 3•18 years ago
|
||
Comment on attachment 259406 [details] [diff] [review]
v1
>Index: xpcom/base/nsCycleCollector.h
>+NS_COM nsresult nsCycleCollector_startup();
Shouldn't be NS_COM, since it's only called from within the XPCOM sharedlib.
r=me with that change.
Attachment #259406 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #259406 -
Attachment is obsolete: true
Attachment #259691 -
Flags: superreview?(dbaron)
Attachment #259691 -
Flags: review+
Comment on attachment 259691 [details] [diff] [review]
v1.1
sr=dbaron
Attachment #259691 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Comment 7•18 years ago
|
||
Removed about 0.5KB from Rlk and about 100KB from Lk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Keywords: mlk,
regression
You need to log in
before you can comment on or make changes to this bug.
Description
•