Closed Bug 375075 Opened 17 years ago Closed 17 years ago

Stop leaking the cycle collector on shutdown

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: peterv, Assigned: peterv)

References

Details

(Keywords: memory-leak, regression)

Attachments

(1 file, 1 obsolete file)

v1.1
24.40 KB, patch
peterv
: review+
dbaron
: superreview+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
This undoes most of the patch for bug 369336.
Attachment #259406 - Flags: review?(benjamin)
Comment on attachment 259406 [details] [diff] [review]
v1

>Index: xpcom/base/nsCycleCollector.h

>+NS_COM nsresult nsCycleCollector_startup();

Shouldn't be NS_COM, since it's only called from within the XPCOM sharedlib.

r=me with that change.
Attachment #259406 - Flags: review?(benjamin) → review+
Attached patch v1.1 — — Splinter Review 

        Attachment #259406 -
        Attachment is obsolete: true

        Attachment #259691 -
        Flags: superreview?(dbaron)

        Attachment #259691 -
        Flags: review+

    
    

    
  
Comment on attachment 259691 [details] [diff] [review]
v1.1

sr=dbaron

        Attachment #259691 -
        Flags: superreview?(dbaron) → superreview+

    
    

    
  
Removed about 0.5KB from Rlk and about 100KB from Lk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
  
Keywords: mlk, 
          
            regression

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: