375190 - loading bookmark/history item from the sidebar that doesn't load a new page causes strange double-focus state

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Brian Polidoro]

I clicked on an entry in planet mozilla's feed for one of David Baron's entries then clicked on his next entry.  But because it was on the same page with just a different anchor the page just scrolled.  But the problem was that the keyboard focus was still in the sidebar.  So pressing the up/down arrows moves the selected entry in sidebar *and* it also scrolls the content area.

1.  Put the planet mozilla feed in your bookmarks.  I'm using the RSS 2.0.  
2.  Click the two David Baron entries one after the other.

Actual:
Pressing the up/down arrow keys moves the sidebar selected entry and scrolls the page.

Expected:
Focus should be in the page.

Comment 1

[Brian Polidoro]

Attachment: feed with just those entries.

Comment 2

[Brian Polidoro]

This isn't a problem in 1.5.0.11 or the most recent 2.0.0.4pre nightly.  

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Which build *is* it a problem in? You should always remember to indicate what build you're testing when filing a bug as NEW.

Comment 4

[Brian Polidoro]

Sorry I thought filing under Firefox, Windows, trunk was telling enough:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070324 Minefield/3.0a3pre ID:2007032408 [cairo]

Comment 5

[Brian Polidoro]

I got back to finding the regression range:
20061014 broke
20061013 works

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-10-13+04%3A00%3A00&maxdate=2006-10-14+04%3A00%3A00&cvsroot=%2Fcvsroot

Bug 232605?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

It's not really clear from your comment how this bug is supposed to be reproduced, but here's my best guess:

1) Add dbaron's feed as a bookmark that opens in the sidebar.
2) Load that bookmark, so you see the feed preview in the sidebar. Click one of the items. Blog entry loads in main content area.
3) Click another item. New item scrolls into view, since it's on the same page.

After these steps, focus is left in the sidebar. That's consistent with clicking a link targeted to a new window, so I'm not sure that that's really a bug.
I can't reproduce the "moves the selected entry in sidebar *and* it also scrolls the content area" problem (arrows only scroll the sidebar).

Comment 7

[Brian Polidoro]

Drat I didn't think of a bookmark opening the feed preview in the sidebar.  That's not what I meant.  Sorry I should have said: Put the planet mozilla feed in your bookmarks *as a live bookmark*.  Or better yet: subscribe to the planet mozilla feed with a live bookmark.  

But using david's feed shows the problem too (I tried the RSS1).  So long as the URL is the same with only the anchor being different.  Which for his blog looks to have all the entries for a month on one page.  
e.g.
http://dbaron.org/log/2007-03#e20070324a
http://dbaron.org/log/2007-03#e20070324b

And actually I see now it doesn't require a live bookmark.  I bookmarked the two entries above and opening them consecutively also shows the problem.

Comment 8

[Brian Polidoro]

Oh and the same thing happens in the history sidebar as well.  

Comment 9

[:Gavin Sharp [email: [e-mail]]]

OK, I can reproduce the problem with the bookmark/history sidebar.

Comment 10

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 11

[Brian Polidoro]

I can reproduce this in 3.5 but not on the trunk 3.6a1pre.  I assume this was fixed by the focus refactoring.