375258 - Cannot send any news message : no connection to news server ?!

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a3pre) Gecko/20070325 Firefox/3.0a3pre
Build Identifier: 

It is a really simple bug to reproduce. Bug was introduced after 23rd march. My last working homemade build was made on 23rd march, around 01:00 am (mozilla.org time).

When I try to send a message on my news server, I get an error message telling me :

"A news (NNTP) error occured : article has no body just headers"

then I have another error box :

"Sending of message failed. The message cannot be sent because connecting to the news server failed..."

Of course, I entered a body, and using an older version, connection is OK !

Reproducible: Always

Steps to Reproduce:
1.Grab / build a nightly after 23rd march
2.Go to a newsgroup
3.Write a message
4.Try to send it
Actual Results:  
Error message. Nothing sent.

Expected Results:  
Just sending the message ?!

Could this be related to bug 33451 or bug 355008 ?!

Comment 1

[Frederic Bezies]

I don't know if it is related, but using 24th march nightly of Thunderbird, I got this in error console :

Error: gMsgCompose.getExternalSendListener is not a function
Source File: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 1056

Comment 2

[Andrew Schultz]

the exception is bug 372706

The regression is from bug 33451 (attachment 259459 [details] [diff] [review])

Comment 3

[Frederic Bezies]

So I guess well for the guilty bug. Hope those kind of regressions will be soon dead ;)

Comment 4

[David :Bienvenu]

hmm, this works fine on Windows, which makes it challenging for me to try to reproduce. I'll try it on the Mac and hope the problem occurs there too. Sorry for the regression. I wonder if Andrew can reproduce this on Linux, using the test newsgroup on news.mozilla.org...

Comment 5

[Andrew Schultz]

David: Yes, I can.  I can try a debug build to see if that complains.  Anything else to look at specifically?

Comment 6

[David :Bienvenu]

(Un)fortunately, the problem happens on the mac, so I can debug it there. My guess is something is going wrong in DeliverFileAsNews. I'll look into it right now - I didn't see any interesting assertions firing. An other possibility is the change to nsAsyncProtocol::PostMessage, though I stepped through it on Windows. Or was that just used for smtp posting - I don't remember anymore...

Comment 7

[David :Bienvenu]

Attachment: proposed fix

we want crlf, not the platform native line ending. Andrew, could you try this on linux, if you get a chance? Thx!

Comment 8

[Andrew Schultz]

Yes, the patch fixes the bug on linux too.

Comment 9

[Frederic Bezies]

I can confirm this patch is working beautifully.

Let's hope it would be added soon ;)

Comment 10

[David :Bienvenu]

fix checked in. Thx for confirming the fix on linux.