375291 - update layout/generic/punct_marks.ccmap to unicode 5.0

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[arno renevier]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070310 Iceweasel/2.0.0.3 (Debian-2.0.0.3-1)
Build Identifier: 

layout/generic/punct_marks.ccmap contains list of   Ps, Pe, Pi, Pf, and Po unicode punctuation classes. That list is used for first-letter. From  CSS2, section 5.12.2:

Punctuation (i.e, characters
defined in Unicode [UNICODE] in the "open" (Ps), "close" (Pe), and "other" (Po)
punctuation classes), that precedes the first letter should be included" in the
first-letter pseudo-element.

That list has been generated in 2004 with Unicode  4.0.1 data file. See (bug 263411).

Now, unicode version is 5.0, and some characters are not the same.

Reproducible: Always

Steps to Reproduce:
see testcase

Comment 1

[arno renevier]

Attachment: testcase

take account of unicode 5.0

Comment 2

[arno renevier]

Attachment: patch proposal

obtained by the method described in bug 263411 comment 2

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 259606 [details] [diff] [review]
patch proposal

Looks good to me, but I'd like smontagu to check as well.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 259606 [details] [diff] [review]
patch proposal

Oops, I totally forgot about this file in bug 345156. 

Do any others of http://lxr.mozilla.org/seamonkey/find?string=ccmap need updating? After answering that question, we should also update http://wiki.mozilla.org/I18n:Updating_Unicode_version

Comment 5

[Nickolay_Ponomarev]

Checked in:
mozilla/layout/generic/punct_marks.ccmap  1.7


Sounds like this can be tested with reftest.

Also, what's with the question in comment 4?

Comment 6

[Simon Montagu :smontagu]

Bug 445877 makes the question in comment 4 moot.