Closed
Bug 375318
Opened 18 years ago
Closed 13 years ago
pyxpcom build failures on trunk
Categories
(Other Applications Graveyard :: PyXPCOM, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: shanec, Unassigned)
References
Details
Attachments
(3 files, 2 obsolete files)
3.02 KB,
patch
|
Details | Diff | Splinter Review | |
1.26 KB,
patch
|
Details | Diff | Splinter Review | |
5.28 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3 Build Identifier: cvs trunk trying to build a "clean" (ie. no komodo patches) xulrunner/pyxpcom build from trunk on osx. I'll attach patches that get it building, and reference a couple other bugs. I don't expect these patches to be final just yet, as it'll need to be tested on all platforms. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Reporter | ||
Comment 1•18 years ago
|
||
The problem with the original was having two -executable_name switches in the link command. gcc on osx errored out with that.
Attachment #259626 -
Flags: review?(mhammond)
Reporter | ||
Comment 2•18 years ago
|
||
for pydom, an attempt was made to link to libpyxpcom.a which does not exist (apparently on linux as well, see bug 355608). Instead, link dynamically to it.
Attachment #259628 -
Flags: review?(mhammond)
Reporter | ||
Comment 3•18 years ago
|
||
slight modification makes pyxpcom work (osx)
Attachment #259626 -
Attachment is obsolete: true
Attachment #259645 -
Flags: review?(mhammond)
Attachment #259626 -
Flags: review?(mhammond)
Reporter | ||
Comment 4•18 years ago
|
||
pydom build fix
Attachment #259628 -
Attachment is obsolete: true
Attachment #259646 -
Flags: review?(mhammond)
Attachment #259628 -
Flags: review?(mhammond)
Reporter | ||
Comment 5•18 years ago
|
||
some notes from benjamin that might help me figure out the correct otptions. mixedpuppy: bsmedberg: have mark on review for it. reason I'm asking you is because it is xpcom glue stuff you were just talking about and not sure mark will know it. it's very small patches [10:40am] bsmedberg: mixedpuppy: what kind of linkage are these trying to use? [10:41am] mixedpuppy: not sure what you're asking. it was the only way I could get pyxpcom/pydom both build and work. [10:41am] mixedpuppy: in xulrunner (trunk) [10:41am] bsmedberg: mixedpuppy: http://developer.mozilla.org/en/docs/XPCOM_Glue [10:42am] sayrer: bsmedberg: same error in xptcall/tests/TestXPTCInvoke, it seems [10:42am] bsmedberg: sayrer: same thing should work, r=me if it does [10:43am] mixedpuppy: bsmedberg: it would be dependent glue, however, doing that generates two entries of "-Wl,-executable_path,/path/to/xulrunner-bin" on the link line, which breaks the build. [10:43am] antonio_blanca left the chat room. (Connection reset by peer) [10:43am] bsmedberg: mixedpuppy: it looks like their trying to use dependent linkage, with a few quirks [10:43am] bsmedberg: mixedpuppy: do you know where the two come from? [10:43am] mixedpuppy: osx gcc rejects two -executable_path entries [10:43am] bsmedberg: MOZ_COMPONENT_LIBS doesn't look right [10:44am] bsmedberg: should be XPCOM_GLUE_LDOPTS + NSPR_LIBS [10:44am] mixedpuppy: hmm, I'm pretty sure I tried that [10:44am] jeremy joined the chat room. [10:44am] mixedpuppy: am going to build on all three platforms today, so I will try that. [10:45am] bsmedberg: mixedpuppy: and module/Makefile.in is trying to use standalone linkage [10:45am] mixedpuppy: yes I know, it was the only way it would build/link correctly for it to be loaded by python [10:45am] bsmedberg: but is using MOZ_COMPONENT_LIBS, which doesn't make any sense [10:45am] mixedpuppy: has to do with what ends up on the link line [10:45am] bsmedberg: standalone linkage is probably correct for that [10:46am] bsmedberg: assuming that the goal is to produce a python module binary that will load XPCOM [10:46am] mixedpuppy: yes, inside of xulrunner [10:47am] bsmedberg: however, it doesn't define XPCOM_GLUE [10:47am] bsmedberg: which kinda defeats the point [10:47am] bsmedberg: you'd have to have your PATH or LD_LIBRARY_PATH set up in advance [10:48am] bsmedberg: so frankly, I'm pretty sure this patch is wrong, but I don't know what's right [10:48am]
Alternative patch to above. Leaves in old syntax, strips out offending -Wl . Also patches PyDOM.
Comment 7•16 years ago
|
||
ack - sorry for letting this slip. The patch looks fine to me, but I will have to take it on faith that it actually fixes builds on Darwin :) Could someone please confirm this patch is still current for Darwin, then I'll apply it.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•16 years ago
|
Assignee: nobody → mhammond
Status: ASSIGNED → NEW
Updated•15 years ago
|
Assignee: mhammond → nobody
Component: Build Config → PyXPCOM
Product: Core → Other Applications
QA Contact: build-config → pyxpcom
Comment 8•13 years ago
|
||
Comment on attachment 259646 [details] [diff] [review] pydom_make.patch This appears to be languishing and is almost certainly out of date.
Attachment #259646 -
Flags: review?(mhammond)
Updated•13 years ago
|
Attachment #259645 -
Flags: review?(mhammond)
Comment 9•13 years ago
|
||
I believe this bug has expired - the Makefile handling has been modified many times over since this time, with latest pyxpcom on Mac OS X building correctly.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•