375449 - NS_InvokeByIndex not exported from xpcom, only from xpcom_core

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Robert Sayre]

Comment 1

[Alex Vincent [:WeirdAl]]

this hit me on Windows too

Comment 2

[Benjamin Smedberg]

Attachment: Export xptcall symbols properly, rev. 1

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 262644 [details] [diff] [review]
Export xptcall symbols properly, rev. 1

r=dbaron

Do the existing callers link to xpcom_core to avoid the performance penalty?  I suppose it's pretty negligible compared to all the other stuff they have to do, though.

Comment 4

[Benjamin Smedberg]

Fixed on trunk. Yes, callers using internal linkage (all the perf-critical ones) will continue to link against the xpcom_core version.

Comment 5

[Alfred Peng]

Attachment: Patch for Solaris SPARC/x86

This must be a typo and breaks Firefox on Solaris.

Comment 6

[Benjamin Smedberg]

Comment on attachment 262738 [details] [diff] [review]
Patch for Solaris SPARC/x86

Yeah, I forgot to add a /g to my regex-replace.

Comment 7

[Alfred Peng]

Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_solaris_SUNW.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_solaris_SUNW.s,v  <--  xptcinvoke_asm_sparc_solaris_SUNW.s
new revision: 1.10; previous revision: 1.9
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_x86_solaris_SUNW.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_x86_solaris_SUNW.s,v  <--  xptcinvoke_asm_x86_solaris_SUNW.s
new revision: 1.4; previous revision: 1.3
done

=>Checked in.