Closed Bug 375449 Opened 13 years ago Closed 13 years ago

NS_InvokeByIndex not exported from xpcom, only from xpcom_core

Categories

(Core :: XPCOM, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: benjamin)

Details

Attachments

(2 files)

 
this hit me on Windows too
OS: Linux → All
Attachment #262644 - Flags: review?(dbaron)
Comment on attachment 262644 [details] [diff] [review]
Export xptcall symbols properly, rev. 1

r=dbaron

Do the existing callers link to xpcom_core to avoid the performance penalty?  I suppose it's pretty negligible compared to all the other stuff they have to do, though.
Attachment #262644 - Flags: review?(dbaron) → review+
Fixed on trunk. Yes, callers using internal linkage (all the perf-critical ones) will continue to link against the xpcom_core version.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
This must be a typo and breaks Firefox on Solaris.
Attachment #262738 - Flags: review?(benjamin)
Comment on attachment 262738 [details] [diff] [review]
Patch for Solaris SPARC/x86

Yeah, I forgot to add a /g to my regex-replace.
Attachment #262738 - Flags: review?(benjamin) → review+
Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_solaris_SUNW.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_solaris_SUNW.s,v  <--  xptcinvoke_asm_sparc_solaris_SUNW.s
new revision: 1.10; previous revision: 1.9
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_x86_solaris_SUNW.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_x86_solaris_SUNW.s,v  <--  xptcinvoke_asm_x86_solaris_SUNW.s
new revision: 1.4; previous revision: 1.3
done

=>Checked in.
You need to log in before you can comment on or make changes to this bug.