Closed
Bug 375564
Opened 17 years ago
Closed 13 years ago
Remove ifdefs for 10.4 in Mac a11y code
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: alqahira, Assigned: eeejay)
References
()
Details
(Whiteboard: [bk1])
Attachments
(1 file)
4.91 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
Bug 374362 fixed building Mac a11y in the default PPC config by just ifdefing the 10.4u SDK-only stuff, but Håkan noted the better way to fix it is to declare the constants ourselves.
Reporter | ||
Comment 1•17 years ago
|
||
Er, wrong blocks/depends; sorry :(
Reporter | ||
Comment 2•17 years ago
|
||
Since the trunk no longer supports 10.3, we can just pull those ifdefs out; rather than closing this and filing a new one, let's just morph ;) There are also some pre-existing self-defined constants in that file that can be un-defined now, too.
Summary: Remove ifdefs for 10.4 in Mac a11y code by declaring our own constants → Remove ifdefs for 10.4 in Mac a11y code
Comment 3•17 years ago
|
||
Sounds good to me, let's use the constants from Apple's headers as much as we can.
Assignee | ||
Comment 5•13 years ago
|
||
I didn't try building this, someone should.
Assignee | ||
Updated•13 years ago
|
Attachment #570987 -
Flags: review?(bolterbugz)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → eitan
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [bk1]
Comment 6•13 years ago
|
||
Comment on attachment 570987 [details] [diff] [review] Remove conditional compiles for pre-10.4 r=me
Attachment #570987 -
Flags: review?(bolterbugz) → review+
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5de05fbcdc67
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•