Remove ifdefs for 10.4 in Mac a11y code

RESOLVED FIXED in mozilla10

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: eeejay)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [bk1], URL)

Attachments

(1 attachment)

Bug 374362 fixed building Mac a11y in the default PPC config by just ifdefing the 10.4u SDK-only stuff, but Håkan noted the better way to fix it is to declare the constants ourselves.
Er, wrong blocks/depends; sorry :(
Blocks: 342989
No longer depends on: 342989
Since the trunk no longer supports 10.3, we can just pull those ifdefs out; rather than closing this and filing a new one, let's just morph ;)

There are also some pre-existing self-defined constants in that file that can be un-defined now, too.
Summary: Remove ifdefs for 10.4 in Mac a11y code by declaring our own constants → Remove ifdefs for 10.4 in Mac a11y code

Comment 3

10 years ago
Sounds good to me, let's use the constants from Apple's headers as much as we can.
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → nobody
(Assignee)

Comment 5

6 years ago
Created attachment 570987 [details] [diff] [review]
Remove conditional compiles for pre-10.4

I didn't try building this, someone should.
(Assignee)

Updated

6 years ago
Attachment #570987 - Flags: review?(bolterbugz)
(Assignee)

Updated

6 years ago
Assignee: nobody → eitan
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Whiteboard: [bk1]
Comment on attachment 570987 [details] [diff] [review]
Remove conditional compiles for pre-10.4

r=me
Attachment #570987 - Flags: review?(bolterbugz) → review+
https://hg.mozilla.org/mozilla-central/rev/5de05fbcdc67
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.