Closed Bug 375564 Opened 14 years ago Closed 10 years ago

Remove ifdefs for 10.4 in Mac a11y code

Categories

(Core :: Disability Access APIs, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: alqahira, Assigned: eeejay)

References

()

Details

(Whiteboard: [bk1])

Attachments

(1 file)

Bug 374362 fixed building Mac a11y in the default PPC config by just ifdefing the 10.4u SDK-only stuff, but Håkan noted the better way to fix it is to declare the constants ourselves.
Er, wrong blocks/depends; sorry :(
Blocks: osxa11y
No longer depends on: osxa11y
Since the trunk no longer supports 10.3, we can just pull those ifdefs out; rather than closing this and filing a new one, let's just morph ;)

There are also some pre-existing self-defined constants in that file that can be un-defined now, too.
Summary: Remove ifdefs for 10.4 in Mac a11y code by declaring our own constants → Remove ifdefs for 10.4 in Mac a11y code
Sounds good to me, let's use the constants from Apple's headers as much as we can.
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → nobody
I didn't try building this, someone should.
Attachment #570987 - Flags: review?(bolterbugz)
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Whiteboard: [bk1]
Comment on attachment 570987 [details] [diff] [review]
Remove conditional compiles for pre-10.4

r=me
Attachment #570987 - Flags: review?(bolterbugz) → review+
https://hg.mozilla.org/mozilla-central/rev/5de05fbcdc67
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.