37558 - plugin EMBED tag is displayed in browser

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[sean echevarria]

The word 'embed' is displayed in the browser where a plugin is embedded if the 
plugin isn't large enough to write over the text.

For example, the following HTML tag sets width and height to 1:

<EMBED NAME="foo" SRC="mySource.dat" TYPE="myType" WIDTH=1 HEIGHT=1 
PLUGINSPAGE="http://myURL">

The word 'embed' appears in the browser.  However, if width and height are 
sufficiently large, then the word 'embed' does not appear.

'embed' should not appear ever.

Comment 1

[sean echevarria]

Attachment: test case - extraneous 'embed' where plugin is

Comment 2

[sean echevarria]

I added an example case.  I think this is more likely a layout bug rather than 
plugins.

Comment 3

[av (gone)]

Reassigning to layout.

Comment 4

[Kevin McCluskey (gone)]

Where is the embedd text comming from? 
Reassigning to attinasi - Triaging Troy's bug list.

Comment 5

[sean echevarria]

add 4xp keyword

Comment 6

[ekrock's old account (dead)]

DUP 17551. When Andrei checks in the default plug-in handler, you will see the 
puzzle piece for EMBEDs missing plug-ins as you did for 4.x. (It's the exact 
same binary, in fact.)

*** This bug has been marked as a duplicate of 17551 ***

Comment 7

[sean echevarria]

Reopening per Eric.  

The problem here is that the layout is drawing something outside of the plugin 
window.  The plugin draws with the correct height and width, but the 
word 'embed' shows up if the font height is larger than the height specified 
for the plugin in the <embed> tag.

Comment 8

[sean echevarria]

This also occurs for short plugins that are instantiated using the <OBJECT> tag.

Comment 9

[Marc Attinasi]

The word embed is being output by the nsObjectFrame::Paint method. I am doing 
some digging to figure out why it is there, or at least when it was added...

Removal is simple: just cut a couple lines of code...

Comment 10

[Marc Attinasi]

I could not find any indication of why the tag-name is painted by the 
ObjectFrame... I am guessing it is old debug code or something.

I'm attaching a patch that removes the offending code. Andrew, could you please 
review it and let me know if I am breaking anything in plugins? Thanks.

Comment 11

[Marc Attinasi]

Attachment: Patch to get rid of the embed text being drawn for a plugin

Comment 12

[Marc Attinasi]

Noting that the fix is in hand... If somebody wants to nominate this for dogfood 
we might be able to get it checked in, otherwise we wait.

Comment 13

[av (gone)]

Looks like this is right thing to do. I think we can just remove this code.

Comment 14

[Marc Attinasi]

The fix is to remove 3 lines of code that are printing out the element-type. 

I am nominating this for nsbeta2 because it is sooo simple and the bug is really 
ugly when there are plugin on a page and they are given a very small area to 
display in (presumably because they are really viewed in another window). This 
really looks like DEBUG code left in the mainline source (ouch!).

Comment 15

[leger]

Putting on [nsbeta2+] [will be minus on 6/15] radar.

Comment 16

[leger]

Removing 6/15..go ahead..check in.

Comment 17

[Marc Attinasi]

Fix checked in (nsObjectFrame.cpp)

Comment 18

[Chris Petersen]

Fixed in the June 19 build (2000061908).