375607 - mac partial update includes zero byte libxpistub.dylib.bz2 file (and this leads to bug #373908, 100% cpu usage)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

mac partial update includes zero byte libxpistub.dylib.bz2 file

from that mar, firefox-3.0a4pre.en-US.mac.partial.2007032604-2007032704.mar, if you do:

mar -t firefox-3.0a4pre.en-US.mac.partial.2007032604-2007032704.mar | grep "^0" you'll get:

0       0644    Contents/MacOS/libxpistub.dylib.bz2

This zero length file will cause bug #373908, 100% cpu usage

build guru's, any idea why this file is in our update?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

From the last nightly build log
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1174994820.1175000467.25885.gz&fulltext=1
while generating the complete update file:

...
processing Contents/MacOS/libxpcom_core.dylib
processing Contents/MacOS/libxpistub.dylib
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 1: unexpected EOF while looking for matching `"'
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 2: syntax error: unexpected end of file
processing Contents/MacOS/libxpistub.dylib
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 1: unexpected EOF while looking for matching `"'
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 2: syntax error: unexpected end of file
processing Contents/MacOS/libxpistub.dylib
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 1: unexpected EOF while looking for matching `"'
/builds/tinderbox/Fx-Trunk/Darwin_8.8.4_Depend/mozilla/tools/update-packaging/make_full_update.sh: eval: line 2: syntax error: unexpected end of file
processing Contents/MacOS/libxpistub.dylib
...
(then it goes on to barf on the space in "Default Plugin", see bug 375621)

Comment 2

[(not reading, please use [e-mail] instead)]

firefox-3.0a4pre.en-US.mac.partial.2007032904-2007033004.mar does not contain the 0 byte Contents/MacOS/libxpistub.dylib.bz2 files.

Thanks to bsmedberg for fixing bug #375415 which has fixed this issue.