37596 - Treat the default item specially on context menus

Status: RESOLVED FIXED

(Core :: XUL, enhancement, P3)

Description

[Jesse Ruderman]

(This was suggested by [e-mail] in bug 27338)

The "default" option should be bolded on all contexts menu.  By "default" 
option I mean the action that happens when you left-click in the same place.

If there's no default action, don't bold anything.

If ctrl-clicking does something different than normal clicking, pretend that 
ctrl-clicking is the default action.  (Assumption: ability to ctrl-click is 
advertised in the context menu already)

Comment 1

[Matthew T (active 1999-2002)]

I didn't suggest it should be emboldened (?) -- although that would be an 
interesting idea. What I suggested was that popup menus should be allowed to have 
a default item (i.e. the option right next to the mouse pointer when the menu is 
opened) which is not necessarily the topmost item.

As regards this bug, IIRC Windows Explorer does this with some of its context 
menus.

Comment 2

[Mike Pinkerton (not reading bugmail)]

m20, at least

Comment 3

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 4

[sairuh (rarely reading bugmail)]

*spam*: transferring current XP Menu bugs over to jrgm, the new component owner.
feel free to add me to the cc list (unless am the Reporter) of any of these, if
you have any questions/etc.

Comment 5

[Blake Ross]

This styling is already done (in classic at least)...

Comment 6

[Matthew T (active 1999-2002)]

Blake, does that mean XUL now has a concept of a `default' action for a context 
menu, or do individual context menus just hack in this style themselves?

If the former, then as per the discussion in bug 27338, correct treatment of the 
default item would be --
* Windows, X: make the default item bold;
* Mac OS: don't apply any special style to the default item, but position it
  *under* the cursor (not just next to it) when the popup menu is drawn. If there
  is no default item, position the first menu item under the cursor.

Comment 7

[Mike Pinkerton (not reading bugmail)]

depends on 52106 for the mac work. the "bold" for win/unix can be hooked up in
this bug.

Comment 8

[Blake Ross]

marking fixed.  Use default="true" to do this.

Comment 9

[Mike Pinkerton (not reading bugmail)]

when is the default item of a context menu not the first item in the menu? if
it's not, shouldn't the menu be redesigned?

all our context menus put the "default" item first, so it seems (context-click
on the document, then context-click on a link...first items are different)...

Comment 10

[Mike Pinkerton (not reading bugmail)]

fwiw, the "make mac put the mouse under the default item" is a different bug.

Comment 11

[Matthew T (active 1999-2002)]

> when is the default item of a context menu not the first item in the menu?

One example is for a link, when `Back' and `Forward' are the first items in the 
menu (bug 27338), but `Open Link' is the default item. See
<http://bugzilla.mozilla.org/showattachment.cgi?attach_id=13963>.

Comment 12

[Jesse Ruderman]

I don't see anything bolded on context menus, but that's probably because I 
can't find any context menus that include the command that happens when you 
left-click without any modifiers.  Should I file a new bug for Open Link in New 
Window to be bolded when ctrl is held down?

Comment 13

[Blake Ross]

pink's part of this was just to provide the ability (toolkit).  Actually 
setting default items in context menus is XPApps (content).