376270 - Omnibus ad-blocking bug for April

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://www.flickr.com/search/?q=camino&w=all

We want to zap either div[id*="AdBlock"] or td[class*="AdColumn"]

Comment 2

[Chris Lawson (gone)]

Evil Flash ad perma-anchored on the bottom of this page:

http://imdb.com/name/nm0416694/board/nest/58563567

Here's the source:

http://pastebin.mozilla.org/5963

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

<div id="firstOvertureSponsoredLinksBlock"> on http://search.wsbtv.com/query.html?la=en&qt=gwinnett

Comment 4

[Chris Lawson (gone)]

Lots of fun ads on this page (possibly NSFW, depending on how uptight your employer is):

http://www.havadis.net/haberdevami.asp?haberID=3605

cl

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Should have blocked img from http://content.yieldmanager.edgesuite.net/ when I blocked whatever else from them last month....

Comment 6

[Javier Morales]

Had a spat of Ads show up for a few weeks. Camino's author suggested I make an entry here....

Here's the URL: http://www.svextra.com/blogs/gmsv/

The blockbuster ad shows up (although I've not seen most other ads). I saved the html and opened it in Camino and in that case the blockuster ad on the side shows up...

No ads most of the time. I'll add HTML and two screen snaps as attachments.

Comment 7

[Javier Morales]

Attachment: HTML source for blockbuster ads on GMSV

I loaded this page and it showed a blockbuster ad across the top. I saved the html and opened from my local filesystem and it showed a block buster ad on the side (screenshots uploaded separately).

Comment 8

[Javier Morales]

Attachment: GMSV screen snap showing banner ad

Comment 9

[Javier Morales]

Attachment: GMSV screen snap showing side ad

Comment 10

[philippe (part-time)]

On http://lemonde.fr, I randomly get evil flash banners.
embed[src*="pubs.lemonde.fr"] blocks those. All other (legit) flash content comes from other URI.

It is a weird one, most ads on that site are blocked already. Those appear to be coming with help from akamai. And it is very random. A Paris based friend saw those way more often than me.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On various imdb.com pages by rotation: div[id*="swf_300x250"]

On, ahem, "Alternate Camino" https://acamino.bountysource.com/development/version_map,
Google ad iframe with src https://www.google.com/pagead/ads?foo and div[id*="googlead"]

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> http://www.havadis.net/haberdevami.asp?haberID=3605

The only thing we can reasonably do anything about is the ad-block at the bottom:
iframe src=http://reklam.gittigidiyor.com/iframe/show.php, div[id*="reklam"] (reklâm and friends are the Turkish for advertising)

Comment 13

[Simon Fraser [no longer active]]

I hit an iframe on macnn.com coming from
http://adopt.specificclick.net/adopt.sm?l=1217336864&sz=728x90&r=h&rnd=[cachebuster]
The image it contained came from http://cdn.specificmedia.com/

Comment 14

[Javier Morales]

Not sure about the relationship between ads and popups, but I clicked on the first story on this web site and a popup window came up. The web site is at: <http://appleinsider.com/> The popup window lead to this page: <http://www.military.com/deployment?ESRC=vc_deploy.op&np=1>

I added the page source as an attachment.

Comment 15

[Javier Morales]

Attachment: Source for web page that opened popup window

Comment 16

[Stuart Morgan]

Pop-blocking is handled by core, and isn't related to our ad-blocking.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On, e.g., http://www.marketwatch.com/News/Story/coca-cola-talks-glacau-reports/story.aspx?guid=%7BA0BAAFA8%2D0622%2D4E1E%2DA7B2%2DD87FE0D6321E%7D&dist=MorePulse

<div id="Kanoodle360" class="contentBlock adModule">

We block some other Kanoodle stuff, and div[class^="adModule"] seems like a safe bet.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: April Omnibus Ad-Blocking patch

Addresses the issues in this bug and bug 377870 and bug 379008.

Per Sam, we want to take this for the "fake RC" and let it be in the wild for the few weeks until 1.5.

Comment 19

[Mark Mentovai]

Checked in on the trunk and the 1.8[.1] branch.

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Approving for Camino 1.0.5.

Comment 21

[froodian (Ian Leue)]

Landed on MOZILLA_1_8_0_BRANCH.