Formatting is bogus when start and end time don't belong to the same timezone

VERIFIED FIXED in 0.7

Status

VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: dbo, Assigned: dbo)

Tracking

unspecified

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
The print formatter code assumes that all passed in events with all its start and end times relate to the same timezone which need not be the case. E.g. regarding WCAP, endDate are sometimes returned in UTC by the server while the startDate has a specific timezone set.
(Assignee)

Comment 1

12 years ago
Created attachment 260595 [details] [diff] [review]
forcing default timezone for print formatting

proposal patch:
- making sure that the print formatters stick to the default timezone
- making sure that the date formatter uses the same timezone for start/end for intervals

BTW: The late-init code in calUtils.js: calendarDefaultTimezone won't reflect changes to the pref, so I think we should install a pref listener for gDefaultTimezone.
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #260595 - Flags: first-review?(lilmatt)
(Assignee)

Comment 2

12 years ago
Created attachment 260865 [details] [diff] [review]
minor opt for getInTimezone

Since getInTimezone is called lots of times and the timezone is most often the same, those calls are most often only cloning the datetime object. Thus I am proposing this little optimization.
Attachment #260865 - Flags: first-review?(lilmatt)
Comment on attachment 260865 [details] [diff] [review]
minor opt for getInTimezone

This looks okay to me, but I'd rather have mvl or ctalbert take a look.  They're more familiar with this file.
Attachment #260865 - Flags: first-review?(lilmatt) → first-review?(mvl)
Comment on attachment 260595 [details] [diff] [review]
forcing default timezone for print formatting

r=lilmatt
Attachment #260595 - Flags: first-review?(lilmatt) → first-review+
Comment on attachment 260865 [details] [diff] [review]
minor opt for getInTimezone

r=mvl
Attachment #260865 - Flags: first-review?(mvl) → first-review+
Whiteboard: [checkin needed after 0.5]
(Assignee)

Comment 6

11 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7

Comment 7

11 years ago
Verified in thunderbird build 2007071103, task is fixed.
Status: RESOLVED → VERIFIED
Blocks: 386236
You need to log in before you can comment on or make changes to this bug.