uClibc strings/index and childiterator.index conficts

RESOLVED FIXED in mozilla1.9.1a2

Status

()

Core
Layout
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9.1a2
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
Created attachment 260622 [details] [diff] [review]
Possible fix

I'm not sure where it should be fixed in uClibc or in nsChildIterator or in proper  build config environment but,
uClibc/string*.h has
http://www.uclibc.org/cgi-bin/viewcvs.cgi/trunk/uClibc/include/
index(..,..) function, and it conflicts with childiterator.index() function

May be we can undefine uclibc define in childiterator header in uClibc build?

+#ifdef __UCLIBC__
+#undef index
+#endif
+
Attachment #260622 - Flags: review?(bzbarsky)
Attachment #260622 - Attachment is patch: true
Attachment #260622 - Attachment mime type: text/x-patch → text/plain
I don't know when I'll be able to get to this.  It will definitely be weeks.

You may want to look for another reviewer.
Comment on attachment 260622 [details] [diff] [review]
Possible fix

I really won't be able to review this in any sort of sane timeframe.  Please ask someone else.
Attachment #260622 - Flags: review?(bzbarsky)
(Assignee)

Updated

10 years ago
Attachment #260622 - Flags: review?(dbaron)
Comment on attachment 260622 [details] [diff] [review]
Possible fix

This is ugly.  Could you just rename index to position instead?
Attachment #260622 - Flags: review?(dbaron) → review-
r+sr=dbaron on the patch to rename (there's only one caller), for what it's worth.

Comment 5

10 years ago
why not just add a configure check or something which undefs:
__UCLIBC_SUSV3_LEGACY__
__UCLIBC_SUSV3_LEGACY_MACROS__

Updated

10 years ago
Blocks: 401821
romaxa, can we get an updated comment to address comment #4 if this is still an issue?
(Assignee)

Comment 7

9 years ago
Created attachment 297628 [details] [diff] [review]
Comment #3 bugfix
Assignee: nobody → romaxa
Attachment #260622 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #297628 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #297628 - Flags: review? → review?(dbaron)
Comment on attachment 297628 [details] [diff] [review]
Comment #3 bugfix

r=dbaron if you use a lowercase p instead of uppercase, to follow the style around it.
Attachment #297628 - Flags: review?(dbaron) → review+
(Assignee)

Comment 9

9 years ago
Created attachment 332426 [details] [diff] [review]
lowercase p fix
Attachment #297628 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Pushed as 17132:e44f43f9aca0.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in before you can comment on or make changes to this bug.