Created attachment 260622 [details] [diff] [review] Possible fix I'm not sure where it should be fixed in uClibc or in nsChildIterator or in proper build config environment but, uClibc/string*.h has http://www.uclibc.org/cgi-bin/viewcvs.cgi/trunk/uClibc/include/ index(..,..) function, and it conflicts with childiterator.index() function May be we can undefine uclibc define in childiterator header in uClibc build? +#ifdef __UCLIBC__ +#undef index +#endif +
10 years ago
I don't know when I'll be able to get to this. It will definitely be weeks. You may want to look for another reviewer.
Comment on attachment 260622 [details] [diff] [review] Possible fix I really won't be able to review this in any sort of sane timeframe. Please ask someone else.
Comment on attachment 260622 [details] [diff] [review] Possible fix This is ugly. Could you just rename index to position instead?
r+sr=dbaron on the patch to rename (there's only one caller), for what it's worth.
why not just add a configure check or something which undefs: __UCLIBC_SUSV3_LEGACY__ __UCLIBC_SUSV3_LEGACY_MACROS__
romaxa, can we get an updated comment to address comment #4 if this is still an issue?
Created attachment 297628 [details] [diff] [review] Comment #3 bugfix
Comment on attachment 297628 [details] [diff] [review] Comment #3 bugfix r=dbaron if you use a lowercase p instead of uppercase, to follow the style around it.
Created attachment 332426 [details] [diff] [review] lowercase p fix
Pushed as 17132:e44f43f9aca0.