Building with GCC-4.3 and '-pedantic' fail due to extra semi-colons and missing newlines

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: Art Haas, Unassigned)

Tracking

({fixed1.8.1.22})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070405 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a4pre) Gecko/20070405 SeaMonkey/1.5a

Hi.

The development version of GCC has changed various warnings to errors if the '-pedantic' flag is used. Numerous files in the Mozilla tree have extra ';' characters and at least one file does not end with a newline. These problems now result in build failures.

Reproducible: Always

Steps to Reproduce:
1. Install GCC-4.3 development snapshot
2. Try to build Mozilla/SeaMonkey/Firefox
3. See build go boom!
Actual Results:  
 Build failed. :-(

Expected Results:  
 Build succeeds: :-)

I will attach a large patch that fixed the build problems on my machine (Fedora Rawhide and GCC-4.3 from 04/04/07).
The patch touches a large number of files in various directories, but the majority of the individual patches are usually just a few lines long and are the removal of ';' characters.
(Reporter)

Comment 1

10 years ago
Created attachment 260749 [details]
Compressed patchset removing ':' and adding missing newline

Here are the patches.
Could you make that one big patch (use cvs diff -u) and attach the patch file instead of a tar?  It's much easier to take a look at that way.

Summary: Building with GCC-4.3 and '-pedantic' fail due to extra semi-colors and missing newlines → Building with GCC-4.3 and '-pedantic' fail due to extra semi-colons and missing newlines
Status: UNCONFIRMED → NEW
Component: Build Config → Build Config
Ever confirmed: true
Product: Mozilla Application Suite → Core
(Reporter)

Comment 3

10 years ago
Hi.

My attachment is a single file. My description above is not clear when I read now what I wrote a couple of minutes ago. Sorry about that. The 'diffs.gz' file is the output of a 'cvs diff -u' command as you suggested.

Updated

10 years ago
Attachment #260749 - Attachment mime type: application/x-tar → application/x-gzip
(Reporter)

Comment 4

10 years ago
Created attachment 260846 [details] [diff] [review]
Second patch removing more extra ';'

In the initial patch I removed some other changes that are in my tree and carelessly removed these changes to three other files needing editing. This patch contains the fixes for these three files.
(Reporter)

Comment 5

10 years ago
Created attachment 262444 [details]
Compress patch file

Here's an updated patch based on the tree from a day or two ago. The patch is a single file containing the output of 'cvs diff -u' and it is compressed due to size.
Attachment #260749 - Attachment is obsolete: true
Attachment #260846 - Attachment is obsolete: true
Fixed on trunk (rs=me)
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Depends on: 408238
Checked in to 1.8 branch (with bug 317216)
Keywords: fixed1.8.1.22
You need to log in before you can comment on or make changes to this bug.