Closed Bug 376777 Opened 17 years ago Closed 17 years ago

data for "text/uri-list" flavor set in nsIClipboardDragDropHooks::OnCopyOrDrag() is overridden in nsDragService::SourceDataGet()

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tomeu, Assigned: tokoe)

Details

(Keywords: fixed1.8.1.18)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy)
Build Identifier: 

If I add a "text/uri-list" flavor to the nsITransferable passed in nsIClipboardDragDropHooks::OnCopyOrDrag(), nsDragService::SourceDataGet() in gtk2 will override that with the contents in the "text/x-moz-url" flavor.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Version: unspecified → Trunk
You'll need to ask someone to review the patch if you want it to be included in the main tree. See http://www.mozilla.org/owners.html for help with finding the correct reviewer.
Component: OS Integration → Drag and Drop
Product: Firefox → Core
QA Contact: os.integration
Version: Trunk → 1.8 Branch
Attachment #260884 - Flags: review?(roc)
Comment on attachment 260884 [details] [diff] [review]
Patch for only set text/uri-list from x-moz-url when no uri-list has been explicitly set
[Checkin: Comment 5]

thanks!!!
Attachment #260884 - Flags: superreview+
Attachment #260884 - Flags: review?(roc)
Attachment #260884 - Flags: review+
We'll take this on trunk in our tree. We need to discuss whether it should be on branch; it doesn't meet normal branch criteria but as it's Linux-only there's some flexibility here.
Whiteboard: [needs checkin]
Version: 1.8 Branch → Trunk
Landed on the trunk:

cvs commit: Examining widget/src/gtk2
Checking in widget/src/gtk2/nsDragService.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsDragService.cpp,v  <--  nsDragService.cpp
new revision: 1.14; previous revision: 1.13
done
Status: UNCONFIRMED → NEW
Ever confirmed: true
Is there any reason for this bug to still be open?
Whiteboard: [needs checkin]
I left it open because of comment #4.

I don't have a strong feeling and I don't know what are the criteria to land on the branch. Tomeu wrote the patch for OLPC and we are going to use 1.9 there anyway. Though the bug was confusing enough that fixing it might be useful for other embedders on 1.8.
Ah, OK. Branch status doesn't have anything to do with the resolution (we use keywords for that), so I'll mark this FIXED.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
This bug prevents some other code from working correctly and there is no way to circumwent it in higher levels of code, so can that patch be applied to the branch, please?
As it is 'only' for Linux it can't break that much (under the viewpoint that drag'n'drop doesn't work correctly without that patch anyway) ;)

Ciao,
Tobias
Attachment #340312 - Flags: approval1.8.0.15?
Attachment #340312 - Flags: approval1.8.0.15? → approval1.8.1.18?
Comment on attachment 340312 [details] [diff] [review]
Backport for 1.8 branch

Sorry, wrong branch :}
Flags: wanted1.8.1.x+
Comment on attachment 340312 [details] [diff] [review]
Backport for 1.8 branch

Approved for 1.9.0.4, a=dveditz for release-drivers
Attachment #340312 - Flags: approval1.8.1.18? → approval1.8.1.18+
meant approved for 1.8.1.18, like the flag setting.
Assignee: nobody → tokoe
Keywords: checkin-needed
Whiteboard: 1.8 branch checkin needed
Attachment #260884 - Attachment description: Patch for only set text/uri-list from x-moz-url when no uri-list has been explicitly set. → Patch for only set text/uri-list from x-moz-url when no uri-list has been explicitly set [Checkin: Comment 5]
Fix checked into the 1.8 branch
Whiteboard: 1.8 branch checkin needed
Is there a good repro case to verify this fix and the previous problem?
You need to log in before you can comment on or make changes to this bug.