376798 - QueriesToQueryString prefixes the first parameter with an ampersand

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

QueriesToQueryString prefix the first parameter with an ampersand, this is not in sync with getFolderURI/getItemURI and seems generally wrong.

FWIW, this is a regression from bug 319894 which made AppendAmpersandIfNonempty pointless.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Also standardize (implicit) callers of QueryStringToQueries to not prefix the first parameter of the query string with an ampersand.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 260907 [details] [diff] [review]
patch

there's still a query in bookmarksPanel.xul that needs to be updated. with that fix, r=me.

Comment 3

[Asaf Romano (gone)]

Attachment: test

Comment 4

[Asaf Romano (gone)]

Attachment: patch, as checked in

mozilla/browser/base/content/browser-menubar.inc 1.111
mozilla/browser/components/places/content/bookmarkProperties.xul 1.25
mozilla/browser/components/places/content/bookmarksPanel.xul 1.5
mozilla/browser/components/places/content/controller.js 1.142
mozilla/browser/components/places/content/history-panel.xul 1.9
mozilla/browser/components/places/content/moveBookmarks.xul 1.2
mozilla/browser/components/places/content/places.xul 1.70
mozilla/browser/components/preferences/selectBookmark.xul 1.5
mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp 1.26

Comment 5

[Asaf Romano (gone)]

mozilla/toolkit/components/places/tests/unit/test_placeURIs.js initial revision: 1.1

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv