376851 - API for sorting a result by an annotation

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

We need an API for setting a manual sorting method for a result, e.g. for sorting a bookmarks result based on the description annotation.

Comment 1

[Asaf Romano (gone)]

Attachment: sorting callback (for reference only)

So this seems like a really complex design to me after trying to use it for the description case (in particular, I had to duplicate the other sorting methods code if there's no description set) :-/ I'm putting this here for future reference only. Maybe a simpler approach would be to provide a generic annotation-based sorting method.

Comment 2

[Asaf Romano (gone)]

Attachment: sort by annotation support - wip

TODO:
 * add support for other annotation types
 * bump uuids
 * in a follow up, re-sort the result whenever the sorting annotation for a
   an item is changed.
 * in a follow up, notify the view when an annotation for an item is changed.

Comment 3

[Asaf Romano (gone)]

Attachment: ready for prime time

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 261053 [details] [diff] [review]
ready for prime time

the approach seems ok, and thanks for refactoring to simplify the sorting callbacks. however, please have Seth do a second pass on this, as it's a pretty big patch, and i'm not super familiar with some of the apis in use.

as you mentioned on irc, please file follow-ups for query de/serialization and live-update support.

>+/**
>+* XXX: You may only think the two methods below are reliable.

s/only//

>+  // Note we also fall back to the title-sorting route one of the items didn't
>+  // have the annotation set or if both had it set but in a different storage
>+  // type

s/route one/route if one/

Comment 5

[Asaf Romano (gone)]

Comment on attachment 261053 [details] [diff] [review]
ready for prime time

So Seth is away.

Comment 6

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/toolkit/components/places/public/nsIAnnotationService.idl 1.12
mozilla/toolkit/components/places/public/nsINavHistoryService.idl 1.55
mozilla/toolkit/components/places/src/nsAnnotationService.cpp 1.18
mozilla/toolkit/components/places/src/nsNavHistory.cpp 1.117
mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp 1.27
mozilla/toolkit/components/places/src/nsNavHistoryQuery.h 1.14
mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp 1.86
mozilla/toolkit/components/places/src/nsNavHistoryResult.h 1.32

Comment 7

[Robert Sayre]

tested?

Comment 8

[Asaf Romano (gone)]

See blocked bug 376630, I'm working on a full test for sort functionality which includes this sort type too.

Comment 9

[Asaf Romano (gone)]

test on bug 376630.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv