Closed
Bug 376871
Opened 17 years ago
Closed 17 years ago
Remove unused isSeparator: parameter
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.4)
Attachments
(1 file)
|
6.42 KB,
patch
|
bugzilla-graveyard
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
For after release, but I wanted to get it out of my tree. The addBookmark:url:inPosition:isSeparator: call really shouldn't have the isSeparator: parameter, since it doesn't make sense to have a separator with a title and URL. No callers ever use it to make a separator (probably for that reason).
Attachment #260967 -
Flags: review?
|
||
Comment 1•17 years ago
|
||
Comment on attachment 260967 [details] [diff] [review] cleanup r=me. Looks good. Do we know why this was even done this way in the first place?
Attachment #260967 -
Flags: review? → review+
|
Assignee | |
Updated•17 years ago
|
Attachment #260967 -
Flags: superreview?(mikepinkerton)
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → stuart.morgan
|
||
Comment 2•17 years ago
|
||
Comment on attachment 260967 [details] [diff] [review] cleanup rs=pink
Attachment #260967 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•