Remove unused isSeparator: parameter

RESOLVED FIXED in Camino1.6

Status

Camino Graveyard
Bookmarks
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.4})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.4

Details

Attachments

(1 attachment)

6.42 KB, patch
Chris Lawson (gone)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Created attachment 260967 [details] [diff] [review]
cleanup

For after release, but I wanted to get it out of my tree. The addBookmark:url:inPosition:isSeparator: call really shouldn't have the isSeparator: parameter, since it doesn't make sense to have a separator with a title and URL. No callers ever use it to make a separator (probably for that reason).
Attachment #260967 - Flags: review?

Comment 1

11 years ago
Comment on attachment 260967 [details] [diff] [review]
cleanup

r=me. Looks good. Do we know why this was even done this way in the first place?
Attachment #260967 - Flags: review? → review+
(Assignee)

Updated

11 years ago
Attachment #260967 - Flags: superreview?(mikepinkerton)
(Assignee)

Updated

11 years ago
Assignee: nobody → stuart.morgan
Comment on attachment 260967 [details] [diff] [review]
cleanup

rs=pink
Attachment #260967 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 3

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.