Closed
Bug 376894
Opened 18 years ago
Closed 18 years ago
Make DEBUG_PKCS11 work for optimized builds, too
Categories
(NSS :: Build, defect, P3)
NSS
Build
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.8
People
(Reporter: mozbgz, Assigned: julien.pierre)
References
()
Details
Attachments
(1 file)
|
583 bytes,
patch
|
nelson
:
review+
julien.pierre
:
superreview+
|
Details | Diff | Splinter Review |
NSS tech note 2 ("Using the PKCS #11 Module Logger", see URL) says:
> The logger is available by default in debug builds. For optimized builds,
> NSS must be built with the variable DEBUG_PKCS11 set.
Unfortunately, the second statement isn't true right now - for optimized builds, the problem is that when prlog.h gets included by pk11wrap/debug_module.c, the PR_LOG macro will end up with an empty definition. The attached patch fixes this by adding -DFORCE_PR_LOG to the pk11wrap manifest.mn when compiling NSS with DEBUG_PKCS11.
Comment 1•18 years ago
|
||
Comment on attachment 260990 [details] [diff] [review]
allow DEBUG_PKCS11 also for optimized builds
r=nelson for trunk
Attachment #260990 -
Flags: review+
| Assignee | ||
Updated•18 years ago
|
Attachment #260990 -
Flags: superreview+
| Assignee | ||
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Updated•18 years ago
|
Assignee: nobody → julien.pierre.boogz
Priority: -- → P3
Target Milestone: --- → 3.11.8
| Assignee | ||
Comment 2•18 years ago
|
||
Checked in to NSS_3_11_BRANCH :
Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/pk11wrap/manifest.mn,v <-- manifest.mn
new revision: 1.16.2.1; previous revision: 1.16
done
And to the NSS trunk :
Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/pk11wrap/manifest.mn,v <-- manifest.mn
new revision: 1.17; previous revision: 1.16
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•18 years ago
|
Summary: Make DEBUG_PKCS11 working for optimized builds, too → Make DEBUG_PKCS11 work for optimized builds, too
You need to log in
before you can comment on or make changes to this bug.
Description
•