377035 - Want to be able to build trees in a mix of anonymous content

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[[e-mail]]

In particular, I want to be able to write a binding that includes the <tree> element but not the <treechildren> element. Test case coming up.

Comment 1

[[e-mail]]

Attachment: Test case

Comment 2

[[e-mail]]

(In reply to comment #1)
>Created an attachment (id=261142)
>Test case
jar:https://bugzilla.mozilla.org/attachment.cgi?id=261142!/377035.xul

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[Alex Vincent [:WeirdAl]]

Neil, does this affect bug 228831?

Comment 6

[Alex Vincent [:WeirdAl]]

Or bug 235901 (which may be a dupe of something else)?

Comment 7

[[e-mail]]

(In reply to comment #5)
>Neil, does this affect bug 228831?
Only in the case of moving the treechildren out of the binding and using <xbl:children includes="treechildren"/> instead. Note: some CSS required

Comment 8

[[e-mail]]

Attachment: Fix notifications

Otherwise you can't e.g. toggle twisties
(see the demo at http://neil.rashbrook.org/377035.xul)

Comment 9

[[e-mail]]

Notification fix checked in.

Comment 10

[:Gijs (he/him)]

So this latest patch totally broke ChatZilla's userlist. Backed out locally,
that fixed it. The rowCount on the view of the rdf tree we use is 0 even if the
channel  is full of users. I don't really know how or why yet, so if anyone
else does, now would be a good time to say.

Filed bug 380184.

Comment 11

[[e-mail]]

Notification fix backed out.

Comment 12

[[e-mail]]

Attachment: Fix notification fix

It turns out that the existing code relies on a document notification for the top-level treechildren to notice when the tree has gone away, and this was the one notification that my change didn't handle. We don't need this notification because removing the top-level treechildren causes the frame to be destroyed which calls mView->SetTree(nsnull) (thus mBoxObject is always null for that particular notification) so I just unconditionally clear the row cache instead.

Comment 13

[[e-mail]]

Fixed notification fix checked in.