Closed
Bug 377331
Opened 17 years ago
Closed 17 years ago
Aqua textareas should not have gfx shadow
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: alqahira, Assigned: jaas)
References
Details
(Keywords: regression)
Attachments
(3 files)
|
296 bytes,
text/html
|
Details | |
|
16.91 KB,
image/png
|
Details | |
|
20.77 KB,
patch
|
stuart.morgan+bugzilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
screenshot of branch vs trunk appearance
In bug 298111, smfr explicitly changed the way <textarea>s were drawn to make them appear more properly Aqua. Specifically, he got rid of the internal shadow (single-line text fields have the shadow on Mac OS X; multi-line fields do not; see bug 298111 comment 4 and bug 298111 comment 14). (He also tweaked the padding, which ended up a bit too tight; however, this has now regressed also and needs to be tweaked again.)
|
Reporter | |
Comment 1•17 years ago
|
||
|
||
Updated•17 years ago
|
Flags: blocking1.9+
Gecko native themes don't currently differentiate between single-line and multi-line text fields so I added that differentiation. Also, because HITheme doesn't have a way to draw multiline text fields (wtf?) I had to draw it "by hand," which isn't too bad because it is very simple.
Attachment #263880 -
Flags: review?(stuart.morgan)
|
||
Updated•17 years ago
|
Attachment #263880 -
Flags: review?(stuart.morgan) → review+
Attachment #263880 -
Flags: superreview?(pavlov)
Attachment #263880 -
Flags: superreview?(pavlov) → superreview?(roc)
Attachment #263880 -
Flags: superreview?(roc) → superreview+
|
||
Comment 3•17 years ago
|
||
"fix v1.0" (attachment 263880 [details] [diff] [review]) compiles fine for me on Windows.
fixed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•