Closed Bug 377395 Opened 17 years ago Closed 17 years ago

remove .doubleclick.net from network.dns.ipv4OnlyDomains

Categories

(Core :: Networking, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla1.9alpha8

People

(Reporter: jo.hermans, Assigned: jo.hermans)

References

Details

Attachments

(1 file, 1 obsolete file)

.doubleclick.net is currently the only entry in the network.dns.ipv4OnlyDomains blacklist, see bug 68796.

Currently, the domain doesn't present a problem anymore for IPv6 lookups, it must have been fixed between 2005 and now. It's still an IPv4 only network, but the DNS-server doesn't seem to be broken anymore.

http://www.cnri.dit.ie/cgi-bin/check_aaaa.pl?dom=doubleclick.net
http://www.cnri.dit.ie/cgi-bin/check_aaaa.pl?dom=ad.doubleclick.net

Can we remove it from the blacklist ?
Jo, I took a quick look and indeed it seems to be working now. Can you provide a patch to do this? If so, it should be very easy to get it into the tree.
(In reply to comment #1)
> Jo, I took a quick look and indeed it seems to be working now. Can you provide
> a patch to do this? If so, it should be very easy to get it into the tree.
> 

I can't produce a patch because I don't have access to a cvs (anal firewall restrictions ; wincvs can't authenticate), so I can't produce a cvs-diff. I can produce a patch file with "diff -c", but that's not the same thing.

It's only about removing the line at http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js#661 .
Is it really necessary that "network.dns.ipv4OnlyDomains" exist? Isn't it disused?
I've been changing the value of the configuration (.doubleclick.net by any word) more than a year ago and, there hasn't been any problem.  


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/2007040314 Firefox/2.0.0.3 (Ubuntu-feisty)
Flags: blocking1.9?
Somebody please post a patch and request reviews, we should take this.  JHermans, you could just produce a patch against a tarball or against MXR raw.
Flags: blocking1.9? → blocking1.9-
Whiteboard: [wanted-1.9]
Attached patch path -wc (against MXR raw file) (obsolete) — Splinter Review
Attachment #279464 - Flags: superreview?(benjamin)
Attachment #279464 - Flags: review?(benjamin)
that had to be the reverse ofcourse
Assignee: nobody → jo.hermans
Attachment #279464 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #279466 - Flags: superreview?(benjamin)
Attachment #279466 - Flags: review?(benjamin)
Attachment #279464 - Flags: superreview?(benjamin)
Attachment #279464 - Flags: review?(benjamin)
Attachment #279466 - Flags: superreview?(benjamin)
Attachment #279466 - Flags: superreview+
Attachment #279466 - Flags: review?(benjamin)
Attachment #279466 - Flags: review+
Attachment #279466 - Flags: approval1.9+
Keywords: checkin-needed
Checking in modules/libpref/src/init/all.js;
/cvsroot/mozilla/modules/libpref/src/init/all.js,v  <--  all.js
new revision: 3.691; previous revision: 3.690
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Also, cound you use diff -wu instead of diff -wc next time? Unified diffs are smaller and easier to read.
(In reply to comment #8)
> Also, cound you use diff -wu instead of diff -wc next time? Unified diffs are
> smaller and easier to read.
> 

Can't, the diff on Solaris 9 doesn't support -u

Verified as fixed in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090604 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9 M8
Flags: wanted1.9+
Whiteboard: [wanted-1.9]
Blocks: 1673856
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: