Closed
Bug 377410
Opened 18 years ago
Closed 18 years ago
Remove MFCEmbed
Categories
(Core Graveyard :: Installer: MFCEmbed, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
656 bytes,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
MFCEmbed is very poor code that doesn't use good embedding APIs or practices. I'd like to remove it, since people keep trying to base real products off of it.
|
Assignee | |
Comment 1•18 years ago
|
||
This and removing the actual files.
Attachment #261479 -
Flags: review?(dougt)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 261479 [details] [diff] [review]
Remove mfcembed, rev. 1
we never really needed another embedding example. Sorry Chak.
Attachment #261479 -
Flags: review?(dougt) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 4•18 years ago
|
||
This change breaks this link, what is the best example of this now?
http://developer.mozilla.org/en/docs/Mozilla_Embedding_FAQ:How_do_I...#How_do_I_get_popup_windows_working.3F
|
|
||
Comment 5•18 years ago
|
||
Sorry to be clearer it breaks the link given in the embedding FAQ.
http://lxr.mozilla.org/mozilla/source/embedding/tests/mfcembed/MfcEmbed.cpp#688
|
|
Assignee | |
Comment 6•18 years ago
|
||
Well, that example no longer exists. Epiphany and other gecko-based browsers implement this solution, however.
Benjamin, should this checkin also have removed references to the mfcembed makefiles from allmakefiles.sh?
|
||
Updated•17 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•