Closed Bug 377410 Opened 17 years ago Closed 17 years ago

Remove MFCEmbed

Categories

(Core Graveyard :: Installer: MFCEmbed, defect)

Product:
Core Graveyard
Component:
Installer: MFCEmbed
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

Remove mfcembed, rev. 1
656 bytes, patch
dougt
: review+
Details | Diff | Splinter Review 
MFCEmbed is very poor code that doesn't use good embedding APIs or practices. I'd like to remove it, since people keep trying to base real products off of it.
This and removing the actual files.
Attachment #261479 - Flags: review?(dougt)
Comment on attachment 261479 [details] [diff] [review]
Remove mfcembed, rev. 1

we never really needed another embedding example.  Sorry Chak.
Attachment #261479 - Flags: review?(dougt) → review+
fixed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Sorry to be clearer it breaks the link given in the embedding FAQ.
http://lxr.mozilla.org/mozilla/source/embedding/tests/mfcembed/MfcEmbed.cpp#688
Well, that example no longer exists. Epiphany and other gecko-based browsers implement this solution, however.
Benjamin, should this checkin also have removed references to the mfcembed makefiles from allmakefiles.sh?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: