377463 - Scrollbar appears / disappears in week & day view when dragging event past 12pm

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Luc Mousseau]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

With the view configured to display 24 hours, the vertical scrollbar appears / disappears when dragging an event box past the 12pm on the bottom of the view. This bug is easier to see if the event your dragging is a few hours long and is made more obvious after applying the path in Bug 373898 (which eliminates the whitespace at the bottom of the week view with 24 hours displayed).

Reproducible: Always

Steps to Reproduce:
1. Configure the view to always display 24 hours, refresh the view if you still see a scrollbar, it should disappear.
2. Then grab any event box (not one of the grabbers, the whole box) and drag it so that the end of the box falls beyond 12pm (don't release the mouse button).

Actual Results:  
The vertical scrollbar appears when passing the 12pm point and then disappears when you release the mouse button or drag the event back before the 12pm point.


Expected Results:  
With 24 hours displayed, no scrollbar should ever appear as they serve no purpose.

Comment 1

[Luc Mousseau]

Attachment: Patch v1

Sets overflow hidden on the timebar and daybox for 24 hour view in vertical only. I'm not sure the horizontal view is really affected by this bug, but it has other issues anyway.

Comment 2

[Martin Schröder [:mschroeder]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070409 Calendar/0.5pre.

Comment 3

[Michael Büttner (no reviews TFN)]

Comment on attachment 261527 [details] [diff] [review]
Patch v1

This bug appears also under several other circumstances, it is not tied to the 24hrs view. Just configure the week-view to display i.e. 20 hrs and drag a moderate event past the end of the display. You'll notice that the scrollbar moves and shrinks as if it tries to accommodate a much larger area. Since the proposed patch is tied to 24hrs it doesn't fix the problem.

It's easily to find other situations where the scrollbar behaves this way. Just move an event so that the end-time falls exactly at 12:00 PM. Now click the end-grippy and notice how the scrollbar tries to accommodate for the added time-labels that you don't see since they are below the lower end of the window.

This is a tricky bug to fix, at least I'd bet it needs to involve some css-hacks. I didn't try this out at home, but probably an idea is to wrap the whole view inside a box with overflow:hidden or something like this.

Comment 4

[Michael Büttner (no reviews TFN)]

I forgot to mention that the horizontal view has exactly the same problem, just with the horizontal scrollbar. I could reproduce both problems mentioned in comment #3 in the horizontal view as well.

Comment 5

[Luc Mousseau]

Attachment: Patch v2 - simple solution which seems to address all scenarios

Comment 6

[Luc Mousseau]

Attachment: Patch v2 - proper

Comment 7

[Michael Büttner (no reviews TFN)]

Comment on attachment 261734 [details] [diff] [review]
Patch v2 - proper

clean and elegant solution to the problem. thanks for the patch. r=mickey

Comment 8

[Michael Büttner (no reviews TFN)]

although this is a low risk patch, we probably want to hold this off until 0.5 is out of the door.

Comment 9

[Simon Paquet [:sipaq]]

Fix checked in.

Comment 10

[Martin Schröder [:mschroeder]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6pre) Gecko/20070726 Calendar/0.7pre.