377542 - Eliminate duplicate implementation of cert validity time checking

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

Attachment: eliminate duplicated code

Sometime long before NSS 1.5 was released, a second function was written to
determine if a certificate was in its validity period.  The new function 
allowed the caller to specify the time that was to be checked against the 
cert's validity period (whereas the first function always tested against NOW).
The second function also allowed the caller to specify whether or not to 
allow the validity time to be overridden with the timeOK flag in the 
CERTCertificate.  A comment was added to the source for the original function,
CERT_CertTimesValid, saying this:

 * WARNING - this function is depricated, and will go away in the near future.
 *	It has been superseded by CERT_CheckCertValidTimes().

Over a decade later, both functions exist with their sightly different 
implementations.  The attached patch eliminates the duplication of code, 
by reimplementing the older function as a call to the newer one.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Bug 377542.  Eliminate duplicate implementation of cert validity time checking.
r=neil.williams,alexei.volkov

On trunk: 
Checking in certvfy.c; new revision: 1.51; previous revision: 1.50
On 3.11 branch:
Checking in certvfy.c; new revision: 1.44.10.6; previous revision: 1.44.10.5