377577 - Trees are limited to a depth of 32

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[[e-mail]]

While investigating bug 73296 I discovered a hard-coded limit of 32 on the depth of a tree. Unfortunately the test case no longer exists.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I changed mLink into an nsAutoTArray which eliminates mTop too.

I picked the initial size of the array based on the old kMaxDepth but I guess it would probably be better to choose a smaller value or use an nsTArray.

Comment 2

[Neil Deakin]

Comment on attachment 261613 [details] [diff] [review]
Proposed patch

Looks OK.

The only comment might be to change the error message in Append/Push.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 261613 [details] [diff] [review]
Proposed patch

+    return PRBool(GetTop() == aIterator.GetTop());

Not your code, but this PRBool cast is unnecessary

Comment 4

[[e-mail]]

Fix checked in.