[FIX]Inner tables should not get parent style based on outer table pseudo

RESOLVED FIXED in mozilla1.9alpha4

Status

()

Core
Layout
P1
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Trunk
mozilla1.9alpha4
fixed1.8.0.12, fixed1.8.1.4
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.4 +
blocking1.8.0.12 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The patch for bug 323656 missed a case:  If we're in DoGetParentStyleContextFrame with the frame being an _outer_ table, we're actually trying to get the parent for the _inner_ table.  That means we should use the _inner_ table's pseudo when figuring out pseudos.

Patch and tests coming up.
(Assignee)

Updated

11 years ago
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha4
Created attachment 261635 [details] [diff] [review]
Proposed fix
Attachment #261635 - Flags: superreview?(dbaron)
Attachment #261635 - Flags: review?(dbaron)
Why are we calling DoGetParentStyleContextFrame with the frame being an outer table, then?
That's basically what nsTableFrame::GetParentStyleContextFrame does.

The point is that we need to start at the mParent of the outer table, but skip things based on the pseudo of the inner table.  I suppose we could just make DoGetParentStyleContextFrame take a pseudo as an arg or something, but this seemed simpler...
Comment on attachment 261635 [details] [diff] [review]
Proposed fix

ok, r+sr=dbaron
Attachment #261635 - Flags: superreview?(dbaron)
Attachment #261635 - Flags: superreview+
Attachment #261635 - Flags: review?(dbaron)
Attachment #261635 - Flags: review+
Checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 261635 [details] [diff] [review]
Proposed fix

We need this if we're going to take bug 323656 on branches.
Attachment #261635 - Flags: approval1.8.1.4?
Attachment #261635 - Flags: approval1.8.0.12?
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12+
Comment on attachment 261635 [details] [diff] [review]
Proposed fix

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #261635 - Flags: approval1.8.1.4?
Attachment #261635 - Flags: approval1.8.1.4+
Attachment #261635 - Flags: approval1.8.0.12?
Attachment #261635 - Flags: approval1.8.0.12+
Checked in on the branches.
Keywords: fixed1.8.0.12, fixed1.8.1.4
You need to log in before you can comment on or make changes to this bug.