Closed
Bug 377603
Opened 18 years ago
Closed 18 years ago
[FIX]Inner tables should not get parent style based on outer table pseudo
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.8.0.12, fixed1.8.1.4)
Attachments
(1 file)
3.82 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
The patch for bug 323656 missed a case: If we're in DoGetParentStyleContextFrame with the frame being an _outer_ table, we're actually trying to get the parent for the _inner_ table. That means we should use the _inner_ table's pseudo when figuring out pseudos.
Patch and tests coming up.
Assignee | ||
Updated•18 years ago
|
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha4
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #261635 -
Flags: superreview?(dbaron)
Attachment #261635 -
Flags: review?(dbaron)
Why are we calling DoGetParentStyleContextFrame with the frame being an outer table, then?
Assignee | ||
Comment 3•18 years ago
|
||
That's basically what nsTableFrame::GetParentStyleContextFrame does.
The point is that we need to start at the mParent of the outer table, but skip things based on the pseudo of the inner table. I suppose we could just make DoGetParentStyleContextFrame take a pseudo as an arg or something, but this seemed simpler...
Comment on attachment 261635 [details] [diff] [review]
Proposed fix
ok, r+sr=dbaron
Attachment #261635 -
Flags: superreview?(dbaron)
Attachment #261635 -
Flags: superreview+
Attachment #261635 -
Flags: review?(dbaron)
Attachment #261635 -
Flags: review+
Assignee | ||
Comment 5•18 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 261635 [details] [diff] [review]
Proposed fix
We need this if we're going to take bug 323656 on branches.
Attachment #261635 -
Flags: approval1.8.1.4?
Attachment #261635 -
Flags: approval1.8.0.12?
Updated•18 years ago
|
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12+
Comment 7•18 years ago
|
||
Comment on attachment 261635 [details] [diff] [review]
Proposed fix
approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #261635 -
Flags: approval1.8.1.4?
Attachment #261635 -
Flags: approval1.8.1.4+
Attachment #261635 -
Flags: approval1.8.0.12?
Attachment #261635 -
Flags: approval1.8.0.12+
You need to log in
before you can comment on or make changes to this bug.
Description
•