377603 - [FIX]Inner tables should not get parent style based on outer table pseudo

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

The patch for bug 323656 missed a case:  If we're in DoGetParentStyleContextFrame with the frame being an _outer_ table, we're actually trying to get the parent for the _inner_ table.  That means we should use the _inner_ table's pseudo when figuring out pseudos.

Patch and tests coming up.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why are we calling DoGetParentStyleContextFrame with the frame being an outer table, then?

Comment 3

[Boris Zbarsky [:bzbarsky]]

That's basically what nsTableFrame::GetParentStyleContextFrame does.

The point is that we need to start at the mParent of the outer table, but skip things based on the pseudo of the inner table.  I suppose we could just make DoGetParentStyleContextFrame take a pseudo as an arg or something, but this seemed simpler...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261635 [details] [diff] [review]
Proposed fix

ok, r+sr=dbaron

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 261635 [details] [diff] [review]
Proposed fix

We need this if we're going to take bug 323656 on branches.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 261635 [details] [diff] [review]
Proposed fix

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in on the branches.