377612 - move out state change events handling from atk

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Ginn Chen]

why do this change?

-  else if (treeItemAccessible && eventType.EqualsLiteral("select")) {
+
+  if (treeItemAccessible && eventType.EqualsLiteral("select")) {

Nit:
use same line wrap for
+    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
+      new nsAccStateChangeEvent(accessible, nsIAccessibleStates::STATE_CHECKED,
+                                PR_FALSE, isEnabled);
and
+    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
+        new nsAccStateChangeEvent(accessible,
+                                  nsIAccessibleStates::STATE_CHECKED,
+                                  PR_FALSE, isEnabled);

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> why do this change?
> 
> -  else if (treeItemAccessible && eventType.EqualsLiteral("select")) {
> +
> +  if (treeItemAccessible && eventType.EqualsLiteral("select")) {
> 

because we don't need 'else if' anymore, previous 'if' has 'return' instruction.

> Nit:
> use same line wrap for
> +    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
> +      new nsAccStateChangeEvent(accessible,
> nsIAccessibleStates::STATE_CHECKED,
> +                                PR_FALSE, isEnabled);
> and
> +    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
> +        new nsAccStateChangeEvent(accessible,
> +                                  nsIAccessibleStates::STATE_CHECKED,
> +                                  PR_FALSE, isEnabled);
> 

Sorry, didn't get you, can you show me it?

Comment 3

[Ginn Chen]

Comment on attachment 261643 [details] [diff] [review]
patch

I mean first chunk of accessible/src/base/nsRootAccessible.cpp.

+  if (eventType.EqualsLiteral("RadioStateChange")) {
+    PRUint32 state = State(accessible);
+    PRBool isEnabled = state & nsIAccessibleStates::STATE_CHECKED;
+
+    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
+      new nsAccStateChangeEvent(accessible, nsIAccessibleStates::STATE_CHECKED,
+                                PR_FALSE, isEnabled);

and

+  if (eventType.EqualsLiteral("CheckboxStateChange")) {
+    PRUint32 state = State(accessible);
+
+    // prefPane tab is implemented as list items in A11y, so we need to
+    // check nsIAccessibleStates::STATE_SELECTED also.
+    PRBool isEnabled = (state & (nsIAccessibleStates::STATE_CHECKED |
+                        nsIAccessibleStates::STATE_SELECTED)) != 0;
+
+    nsCOMPtr<nsIAccessibleStateChangeEvent> accEvent =
+        new nsAccStateChangeEvent(accessible,
+                                  nsIAccessibleStates::STATE_CHECKED,
+                                  PR_FALSE, isEnabled);

are line wrapped different for
new nsAccStateChangeEvent(accessible, nsIAccessibleStates::STATE_CHECKED, PR_FALSE, isEnabled);

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2 (for checkin)

with ginn's comment

Comment 5

[alexander :surkov (:asurkov)]

checked in