377620 - [Proto] Event dialog: Localize 'Do you want to save changes?' dialog

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[snotling]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.1.2) Gecko/20070208 Iceweasel/2.0.0.2 (Debian-2.0.0.2+dfsg-1)
Build Identifier: 

The "cancel" event-edit dialog is currently 'hardcoded' in English.
Please localize it.

See <http://mxr.mozilla.org/mozilla/source/calendar/prototypes/wcap/sun-calendar-event-dialog.js#238>.


Reproducible: Always

Steps to Reproduce:
1. Create a new item in a WCAP calendar.
2. Close this edit window.
3. The "cancel" dialog appears.

Comment 1

[Michael Büttner (no reviews TFN)]

Admittedly, that's something I need to take care of.

Comment 2

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

I also found another hardcoded string for which I took the liberty to include it in this patch as well... :-)

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 277101 [details] [diff] [review]
patch v1

Looks fine. The only other string I could find was |&calendar.invitations.dialog.invitations.text;| which is manually put together with |document.title = invitationsText + " (" + aCount + ")";|. It would probably be better to have this in a properties file and use |calendar.invitations.dialog.invitations.text=Invitations (%1$S)| but I assume that this will tear apart the strings having some in the properties file and most in the dtd.

Comment 4

[Michael Büttner (no reviews TFN)]

(In reply to comment #3)
> (From update of attachment 277101 [details] [diff] [review])
> Looks fine. The only other string I could find was
> |&calendar.invitations.dialog.invitations.text;|
This belongs to the invitations dialog which is a totally different story. As far as I know this whole dialog will be moved into the calendar mode pane (we talked about this idea at the Hamburg F2F meeting, you remember?). I would like to address all issues related to this dialog in a bunch of separate bugs, if you don't mind.

Comment 5

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Martin Schröder [:mschroeder]]

|warningNegativeDuration=The end date you entered occurs before the start date| is missing a trailing period.

Comment 7

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; lt; rv:1.8.1.7pre) Gecko/20070825 Calendar/0.7pre.