377663 - <titlebar> should move enclosing popup

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: testcase

A <titlebar> element currently moves the enclosing window. When placed in a xul popup, it doesn't work properly due to the widget coordinates being calculated incorrectly. I think that the <titlebar> should move the enclosing popup instead.

Comment 1

[Neil Deakin]

Attachment: calculate coordinates differently

Not sure about these widget coordinate calculations.

Also, I made the <titlebar> element only work in chrome shells.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+         nsIWidget* widget = GetClosestView()->GetNearestWidget(&pnt);

Just call this->GetWindow()?

+           // if the widget is the root frame, move the window, otherwise move
+           // the widget

So if the titlebar is in a widget that's not a popup (say a scrollbox), then this will move it? That seems unwise.

Comment 3

[Neil Deakin]

Attachment: make sure the widget is associated with a popup