377808 - 0x7d ("}") should be disallowed in hostnames

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Brian Ryner (not reading)]

The comments in net_IsValidHostName() say that the character "}" (0x7d) is disallowed, but the invalid character list actually contains 0x7e ("~") instead.  Probably it should contain both characters.

(marking security sensitive just in case, but I have no idea if this can be exploited somehow)

Comment 1

[Jesse Ruderman]

Attachment: patch: add } to blacklist, keep ~ on blacklist

I checked that the rest of the blacklist comment matches the actual blacklist, and it does.

Comment 2

[Jesse Ruderman]

The patch in bug 355181 is better.

Comment 3

[Daniel Veditz [:dveditz]]

Rather than dupe it, let's take this as a minimal 1.8-branch fix.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 297274 [details] [diff] [review]
patch: add } to blacklist, keep ~ on blacklist

sr=dveditz, not sure that's good enough for r= here.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 297274 [details] [diff] [review]
patch: add } to blacklist, keep ~ on blacklist

approved for 1.8.1.12, a=dveditz

Comment 6

[Daniel Veditz [:dveditz]]

wanted (patch approved) but not blocking if it doesn't make it.

Comment 7

[Jesse Ruderman]

Attachment: Branch version of patch

Comment 8

[Jesse Ruderman]

Landed on branch.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm verifying via Bonsai, since that seems the best use of my time (and is accurate):

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsURLHelper.cpp&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.60.2.4&rev2=1.60.2.5

Replacing fixed1.8.1.12 with verified1.8.1.12

Comment 10

[Jesse Ruderman]

Michal Novotny fixed this on trunk in bug 355181.