377824 - [FIX]mtable causes "ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere"

Status: RESOLVED FIXED

(Core :: MathML, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere: 'aChildPseudo != nsCSSAnonBoxes::mozAnonymousBlock && aChildPseudo != nsCSSAnonBoxes::mozAnonymousPositionedBlock', nsFrame.cpp, line 5494

This assertion was added in bug 323656.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Mm.... so MathML is reusing the mozAnonymousBlock pseudo that really only {ib} splits should be using.  I suppose we can comment out the assertion until after MathML switches to inline-table, or give MathML its own pseudo.

I'd prefer the latter approach, frankly, but on branches maybe we need to do the former.

Comment 2

[Boris Zbarsky [:bzbarsky]]

David, let me know whether you have a preference, ok?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems like its own pseudo is better.

I don't think content can style these pseudos, so I don't think there should be any issues for branch.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Let's do that.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 261912 [details] [diff] [review]
Let's do that.

r+sr=dbaron

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 261912 [details] [diff] [review]
Let's do that.

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in on the branches.

Comment 9

[Jesse Ruderman]

Crashtest checked in.