Closed Bug 377824 Opened 13 years ago Closed 13 years ago

[FIX]mtable causes "ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere"

Categories

(Core :: MathML, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha4

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(5 keywords)

Attachments

(2 files)

Attached file testcase
Loading the testcase triggers:

###!!! ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere: 'aChildPseudo != nsCSSAnonBoxes::mozAnonymousBlock && aChildPseudo != nsCSSAnonBoxes::mozAnonymousPositionedBlock', nsFrame.cpp, line 5494

This assertion was added in bug 323656.
Mm.... so MathML is reusing the mozAnonymousBlock pseudo that really only {ib} splits should be using.  I suppose we can comment out the assertion until after MathML switches to inline-table, or give MathML its own pseudo.

I'd prefer the latter approach, frankly, but on branches maybe we need to do the former.
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
David, let me know whether you have a preference, ok?
Seems like its own pseudo is better.

I don't think content can style these pseudos, so I don't think there should be any issues for branch.
Attached patch Let's do that.Splinter Review
Assignee: rbs → bzbarsky
Status: NEW → ASSIGNED
Attachment #261912 - Flags: superreview?(dbaron)
Attachment #261912 - Flags: review?(dbaron)
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Summary: mtable causes "ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere" → [FIX]mtable causes "ASSERTION: Should have dealt with kids that have NS_FRAME_IS_SPECIAL elsewhere"
Target Milestone: --- → mozilla1.9alpha4
Flags: blocking1.8.1.4?
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12?
Flags: blocking1.8.0.12+
Comment on attachment 261912 [details] [diff] [review]
Let's do that.

r+sr=dbaron
Attachment #261912 - Flags: superreview?(dbaron)
Attachment #261912 - Flags: superreview+
Attachment #261912 - Flags: review?(dbaron)
Attachment #261912 - Flags: review+
Attachment #261912 - Flags: approval1.8.1.4?
Attachment #261912 - Flags: approval1.8.0.12?
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Comment on attachment 261912 [details] [diff] [review]
Let's do that.

approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #261912 - Flags: approval1.8.1.4?
Attachment #261912 - Flags: approval1.8.1.4+
Attachment #261912 - Flags: approval1.8.0.12?
Attachment #261912 - Flags: approval1.8.0.12+
Checked in on the branches.
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.