The default bug view has changed. See this FAQ.

StartNonListXMLMethod should contain return NULL, not return JS_FALSE

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

({fixed1.8.0.12, fixed1.8.1.4, regression})

unspecified
fixed1.8.0.12, fixed1.8.1.4, regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
My patch in bug 373082 added:

static JSXML *
StartNonListXMLMethod(JSContext *cx, JSObject **objp, jsval *argv)
{
...
    return JS_FALSE;
}

That JS_FALSE should be return NULL. To bad this is already was duplicated on branches.
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
(Assignee)

Comment 1

10 years ago
Created attachment 261964 [details] [diff] [review]
Fix

Extremely safe fix to remove the compiler warning.
Attachment #261964 - Flags: review?(brendan)
Attachment #261964 - Flags: approval1.8.1.4?
Attachment #261964 - Flags: approval1.8.0.12?

Updated

10 years ago
Attachment #261964 - Flags: review?(brendan) → review+
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
Comment on attachment 261964 [details] [diff] [review]
Fix

Not blocking, but approved for 1.8.0.12 and 1.8.1.4. a=dveditz for release-drivers
Attachment #261964 - Flags: approval1.8.1.4?
Attachment #261964 - Flags: approval1.8.1.4+
Attachment #261964 - Flags: approval1.8.0.12?
Attachment #261964 - Flags: approval1.8.0.12+
(Assignee)

Comment 3

10 years ago
I committed the patch from comment 1 to the trunk:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.155; previous revision: 3.154
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

10 years ago
I committed the patch from comment 1 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.67; previous revision: 3.50.2.66
done
Keywords: fixed1.8.1.4
(Assignee)

Comment 5

10 years ago
I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.38; previous revision: 3.50.2.15.2.37
done
(Assignee)

Updated

10 years ago
Keywords: fixed1.8.0.12

Updated

10 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.