377896 - StartNonListXMLMethod should contain return NULL, not return JS_FALSE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

My patch in bug 373082 added:

static JSXML *
StartNonListXMLMethod(JSContext *cx, JSObject **objp, jsval *argv)
{
...
    return JS_FALSE;
}

That JS_FALSE should be return NULL. To bad this is already was duplicated on branches.

Comment 1

[Igor Bukanov]

Attachment: Fix

Extremely safe fix to remove the compiler warning.

Comment 2

[Daniel Veditz [:dveditz] out until Nov 10]

Comment on attachment 261964 [details] [diff] [review]
Fix

Not blocking, but approved for 1.8.0.12 and 1.8.1.4. a=dveditz for release-drivers

Comment 3

[Igor Bukanov]

I committed the patch from comment 1 to the trunk:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.155; previous revision: 3.154
done

Comment 4

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.67; previous revision: 3.50.2.66
done

Comment 5

[Igor Bukanov]

I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.38; previous revision: 3.50.2.15.2.37
done