Closed
Bug 377896
Opened 17 years ago
Closed 17 years ago
StartNonListXMLMethod should contain return NULL, not return JS_FALSE
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Keywords: fixed1.8.0.12, fixed1.8.1.4, regression)
Attachments
(1 file)
1.06 KB,
patch
|
brendan
:
review+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
My patch in bug 373082 added: static JSXML * StartNonListXMLMethod(JSContext *cx, JSObject **objp, jsval *argv) { ... return JS_FALSE; } That JS_FALSE should be return NULL. To bad this is already was duplicated on branches.
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
Assignee | ||
Comment 1•17 years ago
|
||
Extremely safe fix to remove the compiler warning.
Attachment #261964 -
Flags: review?(brendan)
Attachment #261964 -
Flags: approval1.8.1.4?
Attachment #261964 -
Flags: approval1.8.0.12?
Updated•17 years ago
|
Attachment #261964 -
Flags: review?(brendan) → review+
Updated•17 years ago
|
Flags: blocking1.8.1.4?
Flags: blocking1.8.0.12?
Comment 2•17 years ago
|
||
Comment on attachment 261964 [details] [diff] [review] Fix Not blocking, but approved for 1.8.0.12 and 1.8.1.4. a=dveditz for release-drivers
Attachment #261964 -
Flags: approval1.8.1.4?
Attachment #261964 -
Flags: approval1.8.1.4+
Attachment #261964 -
Flags: approval1.8.0.12?
Attachment #261964 -
Flags: approval1.8.0.12+
Assignee | ||
Comment 3•17 years ago
|
||
I committed the patch from comment 1 to the trunk: Checking in jsxml.c; /cvsroot/mozilla/js/src/jsxml.c,v <-- jsxml.c new revision: 3.155; previous revision: 3.154 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•17 years ago
|
||
I committed the patch from comment 1 to MOZILLA_1_8_BRANCH: Checking in jsxml.c; /cvsroot/mozilla/js/src/jsxml.c,v <-- jsxml.c new revision: 3.50.2.67; previous revision: 3.50.2.66 done
Keywords: fixed1.8.1.4
Assignee | ||
Comment 5•17 years ago
|
||
I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH: Checking in jsxml.c; /cvsroot/mozilla/js/src/jsxml.c,v <-- jsxml.c new revision: 3.50.2.15.2.38; previous revision: 3.50.2.15.2.37 done
Assignee | ||
Updated•17 years ago
|
Keywords: fixed1.8.0.12
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•