Last Comment Bug 377896 - StartNonListXMLMethod should contain return NULL, not return JS_FALSE
: StartNonListXMLMethod should contain return NULL, not return JS_FALSE
Status: RESOLVED FIXED
: fixed1.8.0.12, fixed1.8.1.4, regression
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Igor Bukanov
:
Mentors:
Depends on:
Blocks: 373082
  Show dependency treegraph
 
Reported: 2007-04-18 08:35 PDT by Igor Bukanov
Modified: 2007-05-02 10:08 PDT (History)
2 users (show)
bob: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (1.06 KB, patch)
2007-04-18 08:38 PDT, Igor Bukanov
brendan: review+
dveditz: approval1.8.1.4+
dveditz: approval1.8.0.12+
Details | Diff | Review

Description Igor Bukanov 2007-04-18 08:35:08 PDT
My patch in bug 373082 added:

static JSXML *
StartNonListXMLMethod(JSContext *cx, JSObject **objp, jsval *argv)
{
...
    return JS_FALSE;
}

That JS_FALSE should be return NULL. To bad this is already was duplicated on branches.
Comment 1 Igor Bukanov 2007-04-18 08:38:06 PDT
Created attachment 261964 [details] [diff] [review]
Fix

Extremely safe fix to remove the compiler warning.
Comment 2 Daniel Veditz [:dveditz] 2007-04-18 16:14:33 PDT
Comment on attachment 261964 [details] [diff] [review]
Fix

Not blocking, but approved for 1.8.0.12 and 1.8.1.4. a=dveditz for release-drivers
Comment 3 Igor Bukanov 2007-04-18 19:15:48 PDT
I committed the patch from comment 1 to the trunk:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.155; previous revision: 3.154
done
Comment 4 Igor Bukanov 2007-04-18 19:19:35 PDT
I committed the patch from comment 1 to MOZILLA_1_8_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.67; previous revision: 3.50.2.66
done
Comment 5 Igor Bukanov 2007-04-18 19:23:22 PDT
I committed the patch from comment 1 to MOZILLA_1_8_0_BRANCH:

Checking in jsxml.c;
/cvsroot/mozilla/js/src/jsxml.c,v  <--  jsxml.c
new revision: 3.50.2.15.2.38; previous revision: 3.50.2.15.2.37
done

Note You need to log in before you can comment on or make changes to this bug.