377907 - Replace first-review & second-review flags with review + additional reviews flags

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Asaf Romano (gone)]

We (we? mconnor, benjmain, me) would like to switch the Toolkit product to review + additional reviews flags.

Comment 1

[Benjamin Smedberg]

r=me for this change. We should disable the first-review and second-review flags (but leave existing requests)

Comment 2

[timeless]

status:
lilmatt signed off on calendar migrating. I've sent a requests to addons asking for them to agree.

I've moved all first-review and second-review requests for toolkit and calendar to the core multiplicable review flag. (luser informs me i made at least one error, so after this status, I get to read my damage)

I've changed the first-review hint to indicate that toolkit+calendar shouldn't use the flag (this is the best i can do due to limitations).

second-review is disabled.

at present, there are 10 amo requests and 1 aus request (not sure who to ask).

Comment 3

[timeless]

ok. i ran into a couple of bugs which caused the second-review migration to be painful. i've filed one bug against bugzilla for it, but i'm not certain it's the same problem....

anyway. shaver agreed for addons and there's only one bug in AUS, preed was ok w/ the change. as that bug showed symptoms, i'm leaving the review at least for a bit so bugzilla devs can investigate.

i've disabled first-review and the main review is now available for each of toolkit, calendar, addons, and aus.

that leaves thunderbird and firefox as the odd ones out. thunderbird takes 2 screens (which is tolerable for moving), firefox takes 6 (which is probably too high).

I'm also not a big fan of such moves, because they destroy data about requesters and times (see my position in the newsgroups about changing requests). but oh well.

thanks everyone for their cooperation.