377923 - Visible newline glyph in preformatted text with new textframe

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Simon Montagu :smontagu]

Attachment: Testcase

With the new textframe turned on I see a funny little glyph (a white circle on a black background) at the end of every line in preformatted text.

Comment 1

[Simon Montagu :smontagu]

Comments in gfxFont.h say "\r and \n characters must be ignored completely", but I can't find any code that does so.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Ok, we can fix this by modifying glyph extraction to make all \r and \n characters just call SetCharacterGlyph(offset, g.SetMissing()).

Comment 3

[Karl Tomlinson (:karlt)]

Will need doing for Linux/Pango too, and I assume others.

Comment 4

[Simon Montagu :smontagu]

Doing what comment 2 says leaves us with a bug in caret browsing, where the caret appears to stick at the end of each line as it moves across the invisible newline.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think that's a textframe issue, then.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This patch makes \r, \n and \t guaranteed to be invisible and zero-width on all platforms. This is what nsTextFrameThebes wants. It could be handled by layout but that would require us to keep an extra copy of preformatted text in most situations, which is probably good to avoid (large plain-text files are an important test case).

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 265209 [details] [diff] [review]
fix

switching review to stuart

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in