377937 - Security page in pageInfo dialog is not quite right...

Status: RESOLVED DUPLICATE of bug 377076

(Firefox :: Page Info Window, defect)

Description

[Alfred Kayser]

Issues in the security page in pageInfo dialog:

This is too much, and can be removed:
      <textbox id="security-privacy" readonly="true" multiline="true" class="header"/>

But generally, textbox's and descriptions are mixed. 
I think all textbox's should be description's as they are all just test messages, and not to be edited or copied. 

Furthermore, some items are grouped in a vbox and some not.
Overall this makes the look of this page a messy page.

So, instead of mixing textbox's, description's and a groove, 
why not just use two groupbox's for resp. Verification and Encryption.


Before:
      <textbox id="security-identity" readonly="true" class="header"/>
      <description id="security-identity-text" control="security-identity" flex="1"/>
      <hbox align="center">
        <button id="security-view-cert" label="&securityView.label;"
                accesskey="&securityView.accesskey;"
                oncommand="security.viewCert();"/>
        <description id="security-view-text" control="security-view-cert" flex="1"/>
      </hbox>
      <separator class="groove"/>
      <description id="security-privacy" class="header"/>
      <textbox id="security-privacy" readonly="true" multiline="true" class="header"/>
      <vbox flex="1">
        <description id="security-privacy-msg1" control="security-privacy"/>
        <description id="security-privacy-msg2" control="security-privacy"/>
      </vbox>


Proposal:
      <groupbox>
         <caption id="security-identity" readonly="true" class="header"/>
         <description id="security-identity-text" control="security-identity" flex="1"/>
        <hbox align="center">
          <button id="security-view-cert" label="&securityView.label;"
                  accesskey="&securityView.accesskey;"
                  oncommand="security.viewCert();"/>
          <description id="security-view-text" control="security-view-cert" flex="1"/>
        </hbox>
      </groupbox>
      <groupbox>
        <caption id="security-privacy" class="header"/>
        <description id="security-privacy-msg1" control="security-privacy"/>
        <description id="security-privacy-msg2" control="security-privacy"/>
      </groupbox>

Comment 1

[Florian Quèze [:florian]]

The Security tab is being redesigned in bug 377076.

Comment 2

[Alfred Kayser]

I mark this one now as DUP, and request bug 377076 to take up the 'groupbox/caption' proposal.