377966 - Odd alignment of radio button internal elements on Page Setup dialog

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3

On the Page Setup dialog, with the default theme, radio buttons for portrait/landscape line up a little funny.  

Adding some CSS to printPageSetup.css corrects this.  The attachment shows before and after screenshots, or see http://img136.imageshack.us/img136/8977/pagesetupcssti2.jpg .
 
This CSS added to printPageSetup.css does the trick.
 
Before:
=======
 
.portrait-page {
  list-style-image: url("chrome://global/skin/icons/Portrait.png");
}

.landscape-page {
  list-style-image: url("chrome://global/skin/icons/Landscape.png");
}

After:
======
 
.portrait-page {
  list-style-image: url("chrome://global/skin/icons/Portrait.png");
}
 
.landscape-page {
  list-style-image: url("chrome://global/skin/icons/Landscape.png");
}
 
.radio-label-box {
  -moz-box-align: center;
}

Maybe -moz-box-align: center would be better added to radio.css for all .radio-label-box elements, but I haven't looked into that.
 


Reproducible: Always

Steps to Reproduce:
1. Just open the dialog and look at it

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Attachment: Screenshot of Page Setup dialog showing before and after alignment

Comment 2

[Samuel Sidler (old account; do not CC)]

I don't see an obvious dupe, so confirming. I also see this on trunk using Windows XP.

Reporter, if you're up for making a patch, that'll make it easier to get this bug fixed. See: http://developer.mozilla.org/en/docs/Creating_a_patch

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: Toolkit patch

Comment 4

[Vlado Valastiak [:wladow]]

Attachment: SeaMonkey Modern theme patch

Comment 5

[Samuel Sidler (old account; do not CC)]

Robert can probably direct you to someone who can do the SeaMonkey modern review.

Comment 6

[Robert Kaiser]

Comment on attachment 295956 [details] [diff] [review]
SeaMonkey Modern theme patch

Neil, the "SeaMonkey UI tsar" (see http://www.seamonkey-project.org/dev/project-areas), is probably the best reviewer for Modern.

Comment 7

[[e-mail]]

Comment on attachment 295956 [details] [diff] [review]
SeaMonkey Modern theme patch

This needs to be in radio.css

Comment 8

[Vlado Valastiak [:wladow]]

Attachment: SeaMonkey Modern theme patch v2

Moving code into radio.css per comment #7

Comment 9

[[e-mail]]

Actually, would we be better off putting the align in the XBL instead?

Comment 10

[[e-mail]]

Comment on attachment 295978 [details] [diff] [review]
SeaMonkey Modern theme patch v2

Yeah, this needs to go into radio.xml instead. Sorry to mess you around like this.

Comment 11

[Vlado Valastiak [:wladow]]

Attachment: patch for radio.xml and globalBindings.xml

Besides radio.xml also /winstripe/global/globalBindings.xml needs to be patched as it extends radio.xml. Patch was tested on WinVista with Firefox and SeaMonkey nightlies. Works fine with both default and modern theme.

Comment 12

[[e-mail]]

Comment on attachment 296859 [details] [diff] [review]
patch for radio.xml and globalBindings.xml

Nit: it seems to be more common to put the align between the class and the flex.

Comment 13

[Vlado Valastiak [:wladow]]

Attachment: ready for checkin

this is a patch with comment #12 applied

Comment 14

[Reed Loden [:reed]]

Checking in toolkit/content/widgets/radio.xml;
/cvsroot/mozilla/toolkit/content/widgets/radio.xml,v  <--  radio.xml
new revision: 1.28; previous revision: 1.27
done
Checking in toolkit/themes/winstripe/global/globalBindings.xml;
/cvsroot/mozilla/toolkit/themes/winstripe/global/globalBindings.xml,v  <--  globalBindings.xml
new revision: 1.14; previous revision: 1.13
done