378175 - get rid of AtkChildrenChange structs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Ginn Chen]

Comment on attachment 262388 [details] [diff] [review]
patch

nsAccReorderEvent is never created in this patch.
e.g.
http://lxr.mozilla.org/seamonkey/source/accessible/src/base/nsDocAccessible.cpp#1525
is creating nsAccEvent,
QI it to nsIAccessibleReorderEvent will always fail.

Comment 3

[alexander :surkov (:asurkov)]

Ginn. I'm not sure how much it's right to remove pAtkChildrenChange and do not introduce interface for it. Probably we should change reorder event firing since ATK waits for that information. Also this makes sense for AtkTableChange struct.

Comment 4

[Aaron Leventhal]

Does this also deal with bug 378468?

Comment 5

[Aaron Leventhal]

Attachment: Testcase for correct event firing

Three scenarios:
SHOW + REORDER = children-changed:add
HIDE + REORDER = children-changed:remove
REORDER by itself = children-changed? or maybe children-changed:add with index of -1 as we do now

Unfortunately when MSAA wants 2 events ATK wants 1. Right now nsIAccessible is like MSAA. We'll have to change what nsIAccessible fires to make things sane (perhaps not fire REORDER event unless show/hide is unknown, and then have MSAA layer fire the REORDER event when it sees SHOW or HIDE).

Comment 6

[alexander :surkov (:asurkov)]

Fixed in bug 378468.