378213 - Open Link New Tab Restriction

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Brian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1

In the console, the "browser.link.open_newwindow.restriction" should have a value of 2.When a user has the preference for opening links in new tabs, It shouldnt apply to javascript windows. JS windows usually have a unique size, but with the openlink to new tab is checked,the js windows looks very odd.

Set to value 2 in console to resolve.

Reproducible: Always

Steps to Reproduce:
1. Enable "Open Links to New Tabs"
2.
3.

Comment 1

[Peter Weilbacher]

Firefox has it set to 2 while SeaMonkey inherited the value of 0 from the old suite. Neil, Kairo, is there a reason for not setting it to 2 in SeaMonkey?

Comment 2

[Tony Mechelynck [:tonymec]]

FYI, I just set it to zero in user.js; but I'm still curious. Neil, KaiRo (and maybe others), should this bug be Confirmed or WONTFIXed?

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Personally I'm also in favor of changing our default to 2 in sync with FF.

Confirming in order to make it more likely to get an answer one way or another.

Neil, KaiRo: ping! Maybe take the discussion to m.d.a.seamonkey?

Comment 4

[Robert Kaiser]

So, this is, despite the hard-to-understand description, actually a bug for "open new tabs and not new windows by default"?

If so, I agree that we probably should do it now - if Neil agrees as our "UI tsar".

Comment 5

[[e-mail]]

(In reply to comment #4)
> So, this is, despite the hard-to-understand description, actually a bug for
> "open new tabs and not new windows by default"?
Apparently not, just a bug for "If want new tabs for links with target=_blank then don't divert window.open() with features into new tabs too."

Comment 6

[Robert Kaiser]

I don't understand that description, and probably also don't understand the bug, then. This almost makes me think this is INCOMPLETE or INVALID for not describing the issue understandably for human beings.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #6)
> I don't understand that description, and probably also don't understand the
> bug, then. This almost makes me think this is INCOMPLETE or INVALID for not
> describing the issue understandably for human beings.

I think the initial comment (which is a must-read in any bug if you ask me, and for me that goes without saying) is precise enough. When you look at the pref cited there you'll also understand how the bug got its summary. Whether the summary is appropriate may be up for discussion but this bug certainly contains enough information to understand what it's about so neither INCO nor INV apply. Maybe the summary needs tweaking, but that's about it. I feel that at least the reporter, Neil and me understand what the issue is. One of us can certainly try to explain it in other words again if need be.

Comment 8

[Brian]

Hello.

My apologies for not describing the issue in a more descriptive manner. Perhaps
an example may be more appropriate?

For Example,

With the browser.link.open_newwindow.restriction configuration set to 0 , if
you go to a site such as
bestbuy.com and click on the weekly ad, you will notice the window open in a
new tab. This should not happen. Instead a window should popup with its unique
size.

If you change the browser.link.open_newwindow.restriction setting to 2, and
click on weekly ad again, you will notice the difference.

Please let me know if I  may be of any more assistance.

Comment 9

[Brian]

this being that the open links meant to open in a new window is set to 

A new tab in the current window in Tabbed Browsing Preferences

Comment 10

[Robert Kaiser]

I obviously didn't understand the pref, but I actually do feel that not opening new windows is good when someone has selected he wants tabs instead of new windows.

Still, I'll leave the decision to Neil.

Comment 11

[Brian]

Setting to 2, still gives you the ability to open links in new tabs, just there may be an occasion where a site will want you to use a particular browser window size so that it looks normal.

Comment 12

[Jens Hatlak (:InvisibleSmiley)]

Fixed through bug 505311.