Closed
Bug 378240
Opened 19 years ago
Closed 19 years ago
[FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption
Categories
(Core :: Layout: Tables, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha4
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
211 bytes,
text/html
|
Details | |
|
8.06 KB,
patch
|
bernd_mozilla
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
###!!! ASSERTION: Should have found a parent before this: 'aProspectiveParent->GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::viewportScroll', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5531
|
Assignee | |
Comment 1•19 years ago
|
||
Looks like caption's GetStyleContextParent() has just never been right... I should have thought to test this in bug 323656.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #262326 -
Flags: superreview?(dbaron)
Attachment #262326 -
Flags: review?(bernd_mozilla)
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Summary: "ASSERTION: Should have found a parent before this" with a position:fixed table and a caption → [FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption
Target Milestone: --- → mozilla1.9alpha4
Comment on attachment 262326 [details] [diff] [review]
Fix
sr=dbaron, but shouldn't you have an NS_NOTREACHED before the final return?
Attachment #262326 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Yeah, probably a good idea. I'll add it.
Comment on attachment 262326 [details] [diff] [review]
Fix
with the NS_NOTREACHED that dbaron proposed
Attachment #262326 -
Flags: review?(bernd_mozilla) → review+
|
|
Assignee | |
Comment 5•19 years ago
|
||
Fixed, with the NS_NOTREACHED added.
|
||
Updated•19 years ago
|
Flags: in-testsuite?
|
Reporter | |
Comment 6•19 years ago
|
||
Bug 386014 has a new testcase that triggers the same assertion on trunk.
You need to log in
before you can comment on or make changes to this bug.
Description
•