Closed Bug 378240 Opened 16 years ago Closed 16 years ago

[FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption

Categories

(Core :: Layout: Tables, defect, P1)

Product:
Core
Component:
Layout: Tables
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha4

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
211 bytes, text/html
Details
Fix
8.06 KB, patch
bernd_mozilla
: review+
dbaron
: superreview+
Details | Diff | Splinter Review
Attached file testcase — 
Loading the testcase triggers:

###!!! ASSERTION: Should have found a parent before this: 'aProspectiveParent->GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::viewportScroll', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5531
Attached patch Fix — — Splinter Review 
Looks like caption's GetStyleContextParent() has just never been right...  I should have thought to test this in bug 323656.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #262326 - Flags: superreview?(dbaron)
Attachment #262326 - Flags: review?(bernd_mozilla)
Priority: -- → P1
Summary: "ASSERTION: Should have found a parent before this" with a position:fixed table and a caption → [FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption
Target Milestone: --- → mozilla1.9alpha4
Comment on attachment 262326 [details] [diff] [review]
Fix

sr=dbaron, but shouldn't you have an NS_NOTREACHED before the final return?
Attachment #262326 - Flags: superreview?(dbaron) → superreview+
Yeah, probably a good idea.  I'll add it.
Comment on attachment 262326 [details] [diff] [review]
Fix

with the NS_NOTREACHED that dbaron proposed
Attachment #262326 - Flags: review?(bernd_mozilla) → review+
Fixed, with the NS_NOTREACHED added.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Depends on: 323656
Resolution: --- → FIXED
Flags: in-testsuite?
Bug 386014 has a new testcase that triggers the same assertion on trunk.
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.