[FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption

RESOLVED FIXED in mozilla1.9alpha4

Status

()

P1
normal
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: jruderman, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla1.9alpha4
x86
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
Created attachment 262324 [details]
testcase

Loading the testcase triggers:

###!!! ASSERTION: Should have found a parent before this: 'aProspectiveParent->GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::viewportScroll', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5531
(Assignee)

Comment 1

12 years ago
Created attachment 262326 [details] [diff] [review]
Fix

Looks like caption's GetStyleContextParent() has just never been right...  I should have thought to test this in bug 323656.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #262326 - Flags: superreview?(dbaron)
Attachment #262326 - Flags: review?(bernd_mozilla)
(Assignee)

Updated

12 years ago
Priority: -- → P1
Summary: "ASSERTION: Should have found a parent before this" with a position:fixed table and a caption → [FIX]"ASSERTION: Should have found a parent before this" with a position:fixed table and a caption
Target Milestone: --- → mozilla1.9alpha4
Comment on attachment 262326 [details] [diff] [review]
Fix

sr=dbaron, but shouldn't you have an NS_NOTREACHED before the final return?
Attachment #262326 - Flags: superreview?(dbaron) → superreview+
(Assignee)

Comment 3

12 years ago
Yeah, probably a good idea.  I'll add it.

Comment 4

12 years ago
Comment on attachment 262326 [details] [diff] [review]
Fix

with the NS_NOTREACHED that dbaron proposed
Attachment #262326 - Flags: review?(bernd_mozilla) → review+
(Assignee)

Comment 5

12 years ago
Fixed, with the NS_NOTREACHED added.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Depends on: 323656
Resolution: --- → FIXED

Updated

12 years ago
Flags: in-testsuite?
(Reporter)

Comment 6

12 years ago
Bug 386014 has a new testcase that triggers the same assertion on trunk.
(Reporter)

Comment 7

11 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.