378279 - [suiterunner] Missing sidebar (and wrong tabbrowser) close button in Classic

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Stefan [:stefanh]]

themes/classic/communicator/sidebar/sidebar.css:

79 #sidebar-close-button {
 80   -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
 81   padding: 1px 3px 1px 4px;
 82   list-style-image: url("chrome://global/skin/icons/close-button.gif");
 83 }

close-button.gif exists in winstripe/global/icons, but looking at the jar.mn file it's not included. In pinstripe/global/icons there's no such thing as close-button.gif.

Further: winstripe/global/icons have "Close.gif" and pinstripe/global/icons have "close.gif"...

To fix it right away, I think we have 2 options:

1) Just use the same icon as tabbrowser does (classic/navigator/icons/close.gif)

2) Dump an icon in classic/communicator/icons and use that

Comment 1

[Stefan [:stefanh]]

jftr: Mnyromyr thought 2) sounded good.

Comment 2

[[e-mail]]

Tabbrowser currently uses the "full screen close" icon, because I was lazy.

You should move the global close icon to communicator.

Comment 3

[Stefan [:stefanh]]

Attachment: close-button.gif (from global/icons), to go in communicator/icons

I'm just going to check it in - I assume that we don't care about the history :-)

Comment 4

[Stefan [:stefanh]]

Attachment: Get the right button in sidebar and tabbrowser

I fixed the tabbrowser close button as well.

Comment 5

[[e-mail]]

Comment on attachment 262418 [details]
close-button.gif (from global/icons), to go in communicator/icons

It didn't exactly have a lot of history in the first place ;-)

Comment 6

[[e-mail]]

(In reply to comment #3)
>I'm just going to check it in
Don't forgot to use cvs add -kb (I often forgot...)

Comment 7

[[e-mail]]

(In reply to comment #6)
>(In reply to comment #3)
>>I'm just going to check it in
>Don't forgot to use cvs add -kb (I often forgot...)
^forgot^forget

Comment 8

[[e-mail]]

Comment on attachment 262419 [details] [diff] [review]
Get the right button in sidebar and tabbrowser

>   skin/classic/communicator/icons/autoscroll.png                        (communicator/icons/autoscroll.png)
>   skin/classic/communicator/icons/offline.png                           (communicator/icons/offline.png)
>+  skin/classic/communicator/icons/close-button.gif                      (communicator/icons/close-button.gif)
>   skin/classic/communicator/icons/online.png                            (communicator/icons/online.png)
>   skin/classic/communicator/icons/search.png                            (communicator/icons/search.png)
>   skin/classic/communicator/icons/lock-secure.png                       (communicator/icons/lock-secure.png)
>   skin/classic/communicator/icons/lock-broken.png                       (communicator/icons/lock-broken.png)
>   skin/classic/communicator/icons/lock-insecure.png                     (communicator/icons/lock-insecure.png)
>   skin/classic/communicator/icons/loading.gif                           (communicator/icons/loading.gif)
>   skin/classic/communicator/icons/turbo-systray.gif                     (communicator/icons/turbo-systray.gif)
>   skin/classic/communicator/icons/communicatoricons.png                 (communicator/icons/communicatoricons.png)
Hmm... I guess these were in this funny order when they were .gif files and I didn't think to alphabetise them when we changed over to .png files, but that doesn't excuse adding the close icon between the offline and online icons :-P

Comment 9

[Stefan [:stefanh]]

Comment on attachment 262419 [details] [diff] [review]
Get the right button in sidebar and tabbrowser


> Hmm... I guess these were in this funny order when they were .gif files and I
> didn't think to alphabetise them when we changed over to .png files, but that
> doesn't excuse adding the close icon between the offline and online icons :-P
> 

Uh, hang on -- I'll attach a new patch in few minutes :-/

Comment 10

[Stefan [:stefanh]]

Attachment: New, more "alphabetic", version

A little bit better. I must have been tired last night.

Comment 11

[Stefan [:stefanh]]

Checking in communicator/icons/close-button.gif;
/cvsroot/mozilla/themes/classic/communicator/icons/close-button.gif,v  <--  close-button.gif
initial revision: 1.1
done
Checking in communicator/sidebar/sidebar.css;
/cvsroot/mozilla/themes/classic/communicator/sidebar/sidebar.css,v  <--  sidebar.css
new revision: 1.12; previous revision: 1.11
done
Checking in navigator/tabbrowser.css;
/cvsroot/mozilla/themes/classic/navigator/tabbrowser.css,v  <--  tabbrowser.css
new revision: 1.14; previous revision: 1.13
done
Checking in jar.mn;
/cvsroot/mozilla/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.162; previous revision: 1.161
done