378416 - Need test for bug 221634.

Status: RESOLVED WONTFIX

(Toolkit :: Password Manager, defect)

Description

[Robert Sayre]

to do this, we need to ensure some JS executes between DOMContentLoaded and Pageload. Worryingly, this doesn't work cross-platform, so far.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Hmm. I noticed last week when adding authenticate.sjs (and a foo.html^headers^ attempt) that test files not listed in the makefile don't get copied/linked over to the objdir, and things can fail.

The CVS history for the test Makefile shows that the mlogosm.gif this test needed was never added, so I wonder if that was what was causing the test to fail on the tinderbox (I may have accidentally done something to get it to run locally).

This patch re-enables the test and passes on OS X. Will check on Linux to see if it works there now too.

Comment 2

[Martijn Wargers (dead)]

Did you attach the correct patch?

Comment 3

[Justin Dolske [:Dolske]]

Yeah. The test already exists, it was just removed from the Makefile to stop running it because it seemed broken at the time.

Comment 4

[Justin Dolske [:Dolske]]

Bah.

So, as is (with patch), the test fails on linux because the onload seems to fire immediately. The page's <script> hasn't run, so an error is thrown that |performTest| (the onload handler) isn't defined. I can move the <script> up in the page, but then the test detects that the image loaded before DOMContentLoaded fired... Back to square one.

Serving the image via a .sjs script might be enough to induce a proper delay.

Comment 5

[Justin Dolske [:Dolske]]

Not worth the time to fix.

After I rewrote pwmgr, I went back through some older bugs and added a few tests for things that looked easy to test, to help bootstrap early test coverage.

This isn't testing anything particularly useful, and there are hundreds of other old untested bugs.