Closed
Bug 378561
Opened 18 years ago
Closed 18 years ago
Fire STATE_CHANGE event without specified state
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(1 file)
|
2.07 KB,
patch
|
aaronlev
:
review+
|
Details | Diff | Splinter Review |
in nsDocAccessible::DocLoadCallback
around line 1566
according bug 343136 comment #23
it should be STATE_BUSY
also add a cast to avoid compiler warning
Attachment #262620 -
Flags: review?(aaronleventhal)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 262620 [details] [diff] [review]
patch
That cast shouldn't be necessary. If we need it there then why don't we need it everywehere that we set *aRole in the various impls of GetRole()?
Also in XP code we use NS_STATIC_CAST.
Attachment #262620 -
Flags: review?(aaronleventhal) → review+
Yes, it's not necessary. Just to workaround compiler warning: enumeral mismatch in conditional expression.
Don't like it?
|
|
||
Comment 4•18 years ago
|
||
I'd prefer if/else if that fixes it. Otherwise use NS_STATIC_CAST, since that's the "official" way to cast in XP code.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•